From 3dcda6a102b32eedbfad6777a24276ce04c28a85 Mon Sep 17 00:00:00 2001 From: OldHawk Date: Wed, 27 Jun 2018 17:47:49 +0800 Subject: [PATCH] fix(forums): fixed logic issue when delete first reply in any topic --- .../server/controllers/forums.server.controller.js | 9 +++++++-- 1 file changed, 7 insertions(+), 2 deletions(-) diff --git a/modules/forums/server/controllers/forums.server.controller.js b/modules/forums/server/controllers/forums.server.controller.js index 1157c2ef..d7ff06dc 100644 --- a/modules/forums/server/controllers/forums.server.controller.js +++ b/modules/forums/server/controllers/forums.server.controller.js @@ -1029,8 +1029,13 @@ exports.deleteReply = function (req, res) { if (lastReply === r) { lastReply = topic._replies[topic._replies.length - 2]; } - topic.lastReplyAt = lastReply.createdAt; - topic.lastUser = lastReply.user; + if (lastReply) { + topic.lastReplyAt = lastReply.createdAt; + topic.lastUser = lastReply.user; + } else { + topic.lastReplyAt = undefined; + topic.lastUser = undefined; + } topic.save(function (err) { if (err) {