Commit Graph

12 Commits

Author SHA1 Message Date
Rene Pfeuffer
48b4978a3b Fix privilege escalation in namespaces
This fixes the following security issue:
If a user creates a new repository in a namespace this user had no permission to read any repository from, the user gets OWNER permissions on this namespace and all other permissions are removed from this namespace.

Pushed-by: Rene Pfeuffer<rene.pfeuffer@cloudogu.com>
Co-authored-by: René Pfeuffer<rene.pfeuffer@cloudogu.com>
Committed-by: René Pfeuffer<rene.pfeuffer@cloudogu.com>
2024-07-05 12:24:24 +02:00
Eduard Heimbuch
89c4a20dd5 Add namespace owner on namespace creation
Namespace owner may see the namespace configuration page.

Committed-by: René Pfeuffer<rene.pfeuffer@cloudogu.com>
2024-02-08 14:18:16 +01:00
Eduard Heimbuch
cf4d9cf20f 3.x
Committed-by: Eduard Heimbuch<eduard.heimbuch@cloudogu.com>
Pushed-by: Rene Pfeuffer<rene.pfeuffer@cloudogu.com>
Co-authored-by: René Pfeuffer<rene.pfeuffer@cloudogu.com>
Pushed-by: Eduard Heimbuch<eduard.heimbuch@cloudogu.com>
Committed-by: René Pfeuffer<rene.pfeuffer@cloudogu.com>
2023-11-30 17:02:44 +01:00
Rene Pfeuffer
5149927195 Avoid IllegalStateExceptions
The DefaultNamespaceManager has not been a singleton.
Because of this, instances could be removed before
the event has been handled completely and therefore
the handler could no longer be removed from the queue,
resulting in an IllegalStateException.

By making the manager a singleton, it is no longer
garbage collected and therefore we do not get the
exception any longer.

Committed-by: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Co-authored-by: René Pfeuffer <rene.pfeuffer@cloudogu.com>
2023-09-20 17:36:34 +02:00
René Pfeuffer
ab6be650e9 Simplify permissions 2020-09-22 10:08:30 +02:00
Eduard Heimbuch
bb4874b8c1 user with write permission on namespacesPermissions may also read the namespacePermissions so it is consistent to other permissions 2020-09-21 10:44:12 +02:00
René Pfeuffer
b1c0ec15a7 Heed peer review remarks 2020-09-18 16:02:20 +02:00
René Pfeuffer
69997a67cd Move authorization check to manager 2020-09-18 14:32:04 +02:00
René Pfeuffer
6d6a41372d Fix event bus 2020-09-18 14:32:04 +02:00
René Pfeuffer
4bf6e17377 Cleanup permissions for namespace when it is removed 2020-09-18 14:31:45 +02:00
René Pfeuffer
a24abe245b Invalidate authorization cache when namespace permissions are changed 2020-09-18 14:31:45 +02:00
René Pfeuffer
46267daeda Introduce manager interface for namespaces 2020-09-18 14:31:44 +02:00