From f86e50164b102faad219e99a05218d97dd18649e Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Fri, 17 Jun 2011 18:17:13 +0200 Subject: [PATCH] use method to check for a write request --- .../src/main/java/sonia/scm/web/GitPermissionFilter.java | 9 +++++---- 1 file changed, 5 insertions(+), 4 deletions(-) diff --git a/plugins/scm-git-plugin/src/main/java/sonia/scm/web/GitPermissionFilter.java b/plugins/scm-git-plugin/src/main/java/sonia/scm/web/GitPermissionFilter.java index 2aec8356f0..f182b88098 100644 --- a/plugins/scm-git-plugin/src/main/java/sonia/scm/web/GitPermissionFilter.java +++ b/plugins/scm-git-plugin/src/main/java/sonia/scm/web/GitPermissionFilter.java @@ -57,7 +57,7 @@ public class GitPermissionFilter extends RegexPermissionFilter { /** Field description */ - public static final String PATTERN_WRITEREQUEST = "git-receive-pack"; + public static final String METHOD_READ = "GET"; //~--- constructors --------------------------------------------------------- @@ -70,8 +70,9 @@ public class GitPermissionFilter extends RegexPermissionFilter * @param repositoryManager */ @Inject - public GitPermissionFilter(Provider securityContextProvider, - RepositoryManager repositoryManager) + public GitPermissionFilter( + Provider securityContextProvider, + RepositoryManager repositoryManager) { super(securityContextProvider, repositoryManager); } @@ -101,6 +102,6 @@ public class GitPermissionFilter extends RegexPermissionFilter @Override protected boolean isWriteRequest(HttpServletRequest request) { - return request.getRequestURI().endsWith(PATTERN_WRITEREQUEST); + return !METHOD_READ.equalsIgnoreCase(request.getMethod()); } }