From f6fef3861572eb9f3103ae12174e7cd55098ab49 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ren=C3=A9=20Pfeuffer?= <rene.pfeuffer@cloudogu.com>
Date: Tue, 3 Nov 2020 09:55:49 +0100
Subject: [PATCH] Order arguments

---
 .../main/java/sonia/scm/web/UserAgent.java    | 21 ++++++++-----------
 1 file changed, 9 insertions(+), 12 deletions(-)

diff --git a/scm-core/src/main/java/sonia/scm/web/UserAgent.java b/scm-core/src/main/java/sonia/scm/web/UserAgent.java
index 774bc4444f..0647587a19 100644
--- a/scm-core/src/main/java/sonia/scm/web/UserAgent.java
+++ b/scm-core/src/main/java/sonia/scm/web/UserAgent.java
@@ -21,7 +21,7 @@
  * OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
  * SOFTWARE.
  */
-    
+
 package sonia.scm.web;
 
 //~--- non-JDK imports --------------------------------------------------------
@@ -37,7 +37,7 @@ import static com.google.common.base.Preconditions.checkNotNull;
 //~--- JDK imports ------------------------------------------------------------
 
 /**
- * The software agent that is acting on behalf of a user. The user agent 
+ * The software agent that is acting on behalf of a user. The user agent
  * represents a browser or one of the repository client (svn, git or hg).
  *
  * @author Sebastian Sdorra <s.sdorra@gmail.com>
@@ -49,18 +49,15 @@ public final class UserAgent
   /**
    * Constructs a new user agent
    *
-   *
-   * @param name
-   * @param browser
+   *  @param name
    * @param basicAuthenticationCharset
+   * @param browser
    */
-  private UserAgent(String name, boolean browser,
-                    Charset basicAuthenticationCharset,
-                    boolean scmClient)
+  private UserAgent(String name, Charset basicAuthenticationCharset, boolean browser, boolean scmClient)
   {
     this.name = checkNotNull(name);
-    this.browser = browser;
     this.basicAuthenticationCharset = checkNotNull(basicAuthenticationCharset);
+    this.browser = browser;
     this.scmClient = scmClient;
   }
 
@@ -151,7 +148,7 @@ public final class UserAgent
   //~--- get methods ----------------------------------------------------------
 
   /**
-   * Returns the {@link Charset}, which is used to decode the basic 
+   * Returns the {@link Charset}, which is used to decode the basic
    * authentication header.
    *
    * @return {@link Charset} for basic authentication
@@ -176,7 +173,7 @@ public final class UserAgent
    * Returns {@code true} if UserAgent is a browser.
    *
    *
-   * @return {@code true} if UserAgent is a browser 
+   * @return {@code true} if UserAgent is a browser
    */
   public boolean isBrowser()
   {
@@ -256,7 +253,7 @@ public final class UserAgent
      */
     public UserAgent build()
     {
-      return new UserAgent(name, browser, basicAuthenticationCharset, scmClient);
+      return new UserAgent(name, basicAuthenticationCharset, browser, scmClient);
     }
 
     //~--- fields -------------------------------------------------------------