From f4ab367220baab865d23add96e287e25e48d7512 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Thu, 30 Jul 2020 13:35:34 +0200 Subject: [PATCH] adds key id to the tooltip, which is shown for unknown keys --- .../repos/changesets/Changesets.stories.tsx | 22 +++++++++---------- .../src/repos/changesets/SignatureIcon.tsx | 2 +- 2 files changed, 12 insertions(+), 12 deletions(-) diff --git a/scm-ui/ui-components/src/repos/changesets/Changesets.stories.tsx b/scm-ui/ui-components/src/repos/changesets/Changesets.stories.tsx index bc0f7d2551..df5960ee52 100644 --- a/scm-ui/ui-components/src/repos/changesets/Changesets.stories.tsx +++ b/scm-ui/ui-components/src/repos/changesets/Changesets.stories.tsx @@ -98,7 +98,16 @@ storiesOf("Changesets", module) five ); }) - .add("With Valid Signature", () => { + .add("With unknown signature", () => { + const changeset = copy(three); + changeset.signatures = [{ + keyId: "0x247E908C6FD35473", + type: "gpg", + status: "NOT_FOUND" + }]; + return ; + }) + .add("With valid signature", () => { const changeset = copy(three); changeset.signatures = [{ keyId: "0x247E908C6FD35473", @@ -109,16 +118,7 @@ storiesOf("Changesets", module) }]; return ; }) - .add("With Unkown Signature", () => { - const changeset = copy(three); - changeset.signatures = [{ - keyId: "0x247E908C6FD35473", - type: "gpg", - status: "NOT_FOUND" - }]; - return ; - }) - .add("With Invalid Signature", () => { + .add("With invalid signature", () => { const changeset = copy(three); changeset.signatures = [{ keyId: "0x247E908C6FD35473", diff --git a/scm-ui/ui-components/src/repos/changesets/SignatureIcon.tsx b/scm-ui/ui-components/src/repos/changesets/SignatureIcon.tsx index 57ce8fba38..9f99443be9 100644 --- a/scm-ui/ui-components/src/repos/changesets/SignatureIcon.tsx +++ b/scm-ui/ui-components/src/repos/changesets/SignatureIcon.tsx @@ -62,7 +62,7 @@ const SignatureIcon: FC = ({ signatures, className }) => { } if (signature.status === "NOT_FOUND") { - return `${t("changeset.signatureStatus")}: ${status}`; + return `${t("changeset.signatureStatus")}: ${status}\n${t("changeset.keyId")}: ${signature.keyId}`; } let message = `${t("changeset.keyOwner")}: ${signature.owner ? signature.owner : t("changeset.noOwner")}\n${t("changeset.keyId")}: ${signature.keyId}\n${t(