From f33a32a625737e7793cfb9d0d96040b20bed8361 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Thu, 13 Sep 2012 15:28:08 +0200 Subject: [PATCH] improve logging of client util --- .../main/java/sonia/scm/client/ClientUtil.java | 17 ++++++++++++++--- 1 file changed, 14 insertions(+), 3 deletions(-) diff --git a/scm-clients/scm-client-impl/src/main/java/sonia/scm/client/ClientUtil.java b/scm-clients/scm-client-impl/src/main/java/sonia/scm/client/ClientUtil.java index 7a19c5d916..e01307fed7 100644 --- a/scm-clients/scm-client-impl/src/main/java/sonia/scm/client/ClientUtil.java +++ b/scm-clients/scm-client-impl/src/main/java/sonia/scm/client/ClientUtil.java @@ -66,7 +66,7 @@ public class ClientUtil * @param response */ public static void appendContent(ScmClientException exception, - ClientResponse response) + ClientResponse response) { try { @@ -86,12 +86,18 @@ public class ClientUtil * @param expectedStatusCode */ public static void checkResponse(ClientResponse response, - int expectedStatusCode) + int expectedStatusCode) { int sc = response.getStatus(); if (sc != expectedStatusCode) { + if (logger.isWarnEnabled()) + { + logger.warn("response code {} expected, but {} returned", + expectedStatusCode, sc); + } + sendException(response, sc); } } @@ -109,6 +115,11 @@ public class ClientUtil if (sc >= 300) { + if (logger.isWarnEnabled()) + { + logger.warn("request failed, response code {} returned", sc); + } + sendException(response, sc); } } @@ -152,7 +163,7 @@ public class ClientUtil * @return */ public static WebResource createResource(Client client, String url, - boolean enableLogging) + boolean enableLogging) { WebResource resource = client.resource(url);