renamed general to edit

This commit is contained in:
Florian Scholdei
2019-01-29 08:22:43 +01:00
parent df8f2af341
commit f06d2d67a3
14 changed files with 35 additions and 35 deletions

View File

@@ -10,7 +10,7 @@ type Props = {
t: string => string
};
class GeneralGroupNavLink extends React.Component<Props> {
class EditGroupNavLink extends React.Component<Props> {
isEditable = () => {
return this.props.group._links.update;
};
@@ -25,4 +25,4 @@ class GeneralGroupNavLink extends React.Component<Props> {
}
}
export default translate("groups")(GeneralGroupNavLink);
export default translate("groups")(EditGroupNavLink);

View File

@@ -4,14 +4,14 @@ import React from "react";
import { shallow } from "enzyme";
import "../../../tests/enzyme";
import "../../../tests/i18n";
import GeneralGroupNavLink from "./GeneralGroupNavLink";
import EditGroupNavLink from "./EditGroupNavLink";
it("should render nothing, if the edit link is missing", () => {
const group = {
_links: {}
};
const navLink = shallow(<GeneralGroupNavLink group={group} editUrl='/group/edit'/>);
const navLink = shallow(<EditGroupNavLink group={group} editUrl='/group/edit'/>);
expect(navLink.text()).toBe("");
});
@@ -24,6 +24,6 @@ it("should render the navLink", () => {
}
};
const navLink = shallow(<GeneralGroupNavLink group={group} editUrl='/group/edit'/>);
const navLink = shallow(<EditGroupNavLink group={group} editUrl='/group/edit'/>);
expect(navLink.text()).not.toBe("");
});

View File

@@ -1,2 +1,2 @@
export { default as GeneralGroupNavLink } from "./GeneralGroupNavLink";
export { default as EditGroupNavLink } from "./EditGroupNavLink";
export { default as SetPermissionsNavLink } from "./SetPermissionsNavLink";

View File

@@ -30,7 +30,7 @@ type Props = {
error: Error
};
class GeneralGroup extends React.Component<Props> {
class EditGroup extends React.Component<Props> {
componentDidMount() {
const { group, modifyGroupReset } = this.props;
modifyGroupReset(group);
@@ -116,4 +116,4 @@ const mapDispatchToProps = dispatch => {
export default connect(
mapStateToProps,
mapDispatchToProps
)(withRouter(GeneralGroup));
)(withRouter(EditGroup));

View File

@@ -13,7 +13,7 @@ import {
import { Route } from "react-router";
import { Details } from "./../components/table";
import {
GeneralGroupNavLink,
EditGroupNavLink,
SetPermissionsNavLink
} from "./../components/navLinks";
import type { Group } from "@scm-manager/ui-types";
@@ -26,7 +26,7 @@ import {
} from "../modules/groups";
import { translate } from "react-i18next";
import GeneralGroup from "./GeneralGroup";
import EditGroup from "./EditGroup";
import { getGroupsLink } from "../../modules/indexResource";
import SetPermissions from "../../permissions/components/SetPermissions";
import { ExtensionPoint } from "@scm-manager/ui-extensions";
@@ -99,7 +99,7 @@ class SingleGroup extends React.Component<Props> {
<Route
path={`${url}/settings/general`}
exact
component={() => <GeneralGroup group={group} />}
component={() => <EditGroup group={group} />}
/>
<Route
path={`${url}/settings/permissions`}
@@ -133,7 +133,7 @@ class SingleGroup extends React.Component<Props> {
to={`${url}/settings/general`}
label={t("singleGroup.menu.settingsNavLink")}
>
<GeneralGroupNavLink
<EditGroupNavLink
group={group}
editUrl={`${url}/settings/general`}
/>