From ea9489cbe5eba6f658bc3298b30e4962235b0375 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Sat, 18 Dec 2010 18:21:48 +0100 Subject: [PATCH] improve exception handling --- .../sonia/scm/plugin/PluginException.java | 90 +++++++++++++++++++ .../sonia/scm/plugin/PluginLoadException.java | 2 +- .../plugin/PluginNotInstalledException.java | 90 +++++++++++++++++++ .../repository/AbstractRepositoryHandler.java | 2 - 4 files changed, 181 insertions(+), 3 deletions(-) create mode 100644 scm-core/src/main/java/sonia/scm/plugin/PluginException.java create mode 100644 scm-core/src/main/java/sonia/scm/plugin/PluginNotInstalledException.java diff --git a/scm-core/src/main/java/sonia/scm/plugin/PluginException.java b/scm-core/src/main/java/sonia/scm/plugin/PluginException.java new file mode 100644 index 0000000000..7d863739af --- /dev/null +++ b/scm-core/src/main/java/sonia/scm/plugin/PluginException.java @@ -0,0 +1,90 @@ +/** + * Copyright (c) 2010, Sebastian Sdorra + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, + * this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * 3. Neither the name of SCM-Manager; nor the names of its + * contributors may be used to endorse or promote products derived from this + * software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * + * http://bitbucket.org/sdorra/scm-manager + * + */ + + + +package sonia.scm.plugin; + +/** + * + * @author Sebastian Sdorra + */ +public class PluginException extends RuntimeException +{ + + /** Field description */ + private static final long serialVersionUID = -5370284100147219134L; + + //~--- constructors --------------------------------------------------------- + + /** + * Constructs ... + * + */ + public PluginException() + { + super(); + } + + /** + * Constructs ... + * + * + * @param message + */ + public PluginException(String message) + { + super(message); + } + + /** + * Constructs ... + * + * + * @param cause + */ + public PluginException(Throwable cause) + { + super(cause); + } + + /** + * Constructs ... + * + * + * @param message + * @param cause + */ + public PluginException(String message, Throwable cause) + { + super(message, cause); + } +} diff --git a/scm-core/src/main/java/sonia/scm/plugin/PluginLoadException.java b/scm-core/src/main/java/sonia/scm/plugin/PluginLoadException.java index 1c1f4eee36..3c34e0cb23 100644 --- a/scm-core/src/main/java/sonia/scm/plugin/PluginLoadException.java +++ b/scm-core/src/main/java/sonia/scm/plugin/PluginLoadException.java @@ -37,7 +37,7 @@ package sonia.scm.plugin; * * @author Sebastian Sdorra */ -public class PluginLoadException extends RuntimeException +public class PluginLoadException extends PluginException { /** Field description */ diff --git a/scm-core/src/main/java/sonia/scm/plugin/PluginNotInstalledException.java b/scm-core/src/main/java/sonia/scm/plugin/PluginNotInstalledException.java new file mode 100644 index 0000000000..cb7c1e20ae --- /dev/null +++ b/scm-core/src/main/java/sonia/scm/plugin/PluginNotInstalledException.java @@ -0,0 +1,90 @@ +/** + * Copyright (c) 2010, Sebastian Sdorra + * All rights reserved. + * + * Redistribution and use in source and binary forms, with or without + * modification, are permitted provided that the following conditions are met: + * + * 1. Redistributions of source code must retain the above copyright notice, + * this list of conditions and the following disclaimer. + * 2. Redistributions in binary form must reproduce the above copyright notice, + * this list of conditions and the following disclaimer in the documentation + * and/or other materials provided with the distribution. + * 3. Neither the name of SCM-Manager; nor the names of its + * contributors may be used to endorse or promote products derived from this + * software without specific prior written permission. + * + * THIS SOFTWARE IS PROVIDED BY THE COPYRIGHT HOLDERS AND CONTRIBUTORS "AS IS" + * AND ANY EXPRESS OR IMPLIED WARRANTIES, INCLUDING, BUT NOT LIMITED TO, THE + * IMPLIED WARRANTIES OF MERCHANTABILITY AND FITNESS FOR A PARTICULAR PURPOSE ARE + * DISCLAIMED. IN NO EVENT SHALL THE REGENTS OR CONTRIBUTORS BE LIABLE FOR ANY + * DIRECT, INDIRECT, INCIDENTAL, SPECIAL, EXEMPLARY, OR CONSEQUENTIAL DAMAGES + * (INCLUDING, BUT NOT LIMITED TO, PROCUREMENT OF SUBSTITUTE GOODS OR SERVICES; + * LOSS OF USE, DATA, OR PROFITS; OR BUSINESS INTERRUPTION) HOWEVER CAUSED AND ON + * ANY THEORY OF LIABILITY, WHETHER IN CONTRACT, STRICT LIABILITY, OR TORT + * (INCLUDING NEGLIGENCE OR OTHERWISE) ARISING IN ANY WAY OUT OF THE USE OF THIS + * SOFTWARE, EVEN IF ADVISED OF THE POSSIBILITY OF SUCH DAMAGE. + * + * http://bitbucket.org/sdorra/scm-manager + * + */ + + + +package sonia.scm.plugin; + +/** + * + * @author Sebastian Sdorra + */ +public class PluginNotInstalledException extends PluginException +{ + + /** Field description */ + private static final long serialVersionUID = 3990675453445423469L; + + //~--- constructors --------------------------------------------------------- + + /** + * Constructs ... + * + */ + public PluginNotInstalledException() + { + super(); + } + + /** + * Constructs ... + * + * + * @param message + */ + public PluginNotInstalledException(String message) + { + super(message); + } + + /** + * Constructs ... + * + * + * @param cause + */ + public PluginNotInstalledException(Throwable cause) + { + super(cause); + } + + /** + * Constructs ... + * + * + * @param message + * @param cause + */ + public PluginNotInstalledException(String message, Throwable cause) + { + super(message, cause); + } +} diff --git a/scm-core/src/main/java/sonia/scm/repository/AbstractRepositoryHandler.java b/scm-core/src/main/java/sonia/scm/repository/AbstractRepositoryHandler.java index efbef77f58..940384e05c 100644 --- a/scm-core/src/main/java/sonia/scm/repository/AbstractRepositoryHandler.java +++ b/scm-core/src/main/java/sonia/scm/repository/AbstractRepositoryHandler.java @@ -124,8 +124,6 @@ public abstract class AbstractRepositoryHandler