From e9396f4947ab3aeb839e77825dc6994542704432 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Wed, 7 Nov 2018 13:39:38 +0100 Subject: [PATCH] fixed missing validation update on change --- .../scm-hg-plugin/src/main/js/HgConfigurationForm.js | 10 +++------- 1 file changed, 3 insertions(+), 7 deletions(-) diff --git a/scm-plugins/scm-hg-plugin/src/main/js/HgConfigurationForm.js b/scm-plugins/scm-hg-plugin/src/main/js/HgConfigurationForm.js index aa6e3ac206..2b6fc130bc 100644 --- a/scm-plugins/scm-hg-plugin/src/main/js/HgConfigurationForm.js +++ b/scm-plugins/scm-hg-plugin/src/main/js/HgConfigurationForm.js @@ -52,11 +52,10 @@ class HgConfigurationForm extends React.Component { this.setState({ validationErrors }); + + return validationErrors.length === 0; }; - isValid = () => { - return this.state.validationErrors.length === 0; - }; hasValidationError = (name: string) => { return this.state.validationErrors.indexOf(name) >= 0; @@ -65,10 +64,7 @@ class HgConfigurationForm extends React.Component { handleChange = (value: any, name: string) => { this.setState({ [name]: value - }, () => { - this.updateValidationStatus(); - this.props.onConfigurationChange(this.state, this.isValid()); - }); + }, () => this.props.onConfigurationChange(this.state, this.updateValidationStatus())); }; inputField = (name: string) => {