diff --git a/scm-plugins/scm-git-plugin/src/main/js/GitConfigurationForm.js b/scm-plugins/scm-git-plugin/src/main/js/GitConfigurationForm.js index 630984ad87..be977c53f3 100644 --- a/scm-plugins/scm-git-plugin/src/main/js/GitConfigurationForm.js +++ b/scm-plugins/scm-git-plugin/src/main/js/GitConfigurationForm.js @@ -33,29 +33,19 @@ class GitConfigurationForm extends React.Component { this.state = { ...props.initialConfiguration }; } - isValid = () => { - return !!this.state.repositoryDirectory; - }; handleChange = (value: any, name: string) => { this.setState({ [name]: value - }, () => this.props.onConfigurationChange(this.state, this.isValid())); + }, () => this.props.onConfigurationChange(this.state, true)); }; render() { - const { repositoryDirectory, gcExpression, disabled } = this.state; + const { gcExpression, disabled } = this.state; const { readOnly, t } = this.props; return ( <> - { updateValidationStatus = () => { const requiredFields = [ - "hgBinary", "pythonBinary", "repositoryDirectory", "encoding" + "hgBinary", "pythonBinary", "encoding" ]; const validationErrors = []; @@ -99,7 +98,6 @@ class HgConfigurationForm extends React.Component { {this.inputField("hgBinary")} {this.inputField("pythonBinary")} {this.inputField("pythonPath")} - {this.inputField("repositoryDirectory")} {this.inputField("encoding")} {this.checkbox("useOptimizedBytecode")} {this.checkbox("showRevisionInId")} diff --git a/scm-plugins/scm-hg-plugin/src/main/resources/locales/en/plugins.json b/scm-plugins/scm-hg-plugin/src/main/resources/locales/en/plugins.json index 903f906c7e..504e7d3815 100644 --- a/scm-plugins/scm-hg-plugin/src/main/resources/locales/en/plugins.json +++ b/scm-plugins/scm-hg-plugin/src/main/resources/locales/en/plugins.json @@ -14,8 +14,6 @@ "pythonBinaryHelpText": "Location of Python binary.", "pythonPath": "Python Module Search Path", "pythonPathHelpText": "Python Module Search Path (PYTHONPATH).", - "repositoryDirectory": "Repository directory", - "repositoryDirectoryHelpText": "Location of Mercurial repositories.", "encoding": "Encoding", "encodingHelpText": "Repository Encoding.", "useOptimizedBytecode": "Optimized Bytecode (.pyo)", diff --git a/scm-plugins/scm-svn-plugin/src/main/js/SvnConfigurationForm.js b/scm-plugins/scm-svn-plugin/src/main/js/SvnConfigurationForm.js index 9470550ef2..3fde8c7888 100644 --- a/scm-plugins/scm-svn-plugin/src/main/js/SvnConfigurationForm.js +++ b/scm-plugins/scm-svn-plugin/src/main/js/SvnConfigurationForm.js @@ -5,7 +5,6 @@ import { translate } from "react-i18next"; import { InputField, Checkbox, Select } from "@scm-manager/ui-components"; type Configuration = { - repositoryDirectory: string, compatibility: string, enabledGZip: boolean, disabled: boolean, @@ -31,14 +30,11 @@ class HgConfigurationForm extends React.Component { this.state = { ...props.initialConfiguration, validationErrors: [] }; } - isValid = () => { - return !!this.state.repositoryDirectory; - }; handleChange = (value: any, name: string) => { this.setState({ [name]: value - }, () => this.props.onConfigurationChange(this.state, this.isValid())); + }, () => this.props.onConfigurationChange(this.state, true)); }; compatibilityOptions = (values: string[]) => { @@ -64,16 +60,6 @@ class HgConfigurationForm extends React.Component { return ( <> -