From e141e33aa341ac387abdac7eb0ae56df9e5b58b7 Mon Sep 17 00:00:00 2001
From: Florian Scholdei <florian.scholdei@cloudogu.com>
Date: Wed, 21 Oct 2020 12:23:58 +0200
Subject: [PATCH] Clarify prop usage by renaming in more self-evident name

---
 .../src/buttons/OpenInFullscreenButton.tsx           | 12 ++++++++----
 .../src/repos/sources/containers/Content.tsx         |  2 +-
 2 files changed, 9 insertions(+), 5 deletions(-)

diff --git a/scm-ui/ui-components/src/buttons/OpenInFullscreenButton.tsx b/scm-ui/ui-components/src/buttons/OpenInFullscreenButton.tsx
index 707e86055e..c1cd1c6da2 100644
--- a/scm-ui/ui-components/src/buttons/OpenInFullscreenButton.tsx
+++ b/scm-ui/ui-components/src/buttons/OpenInFullscreenButton.tsx
@@ -31,7 +31,7 @@ import Tooltip from "../Tooltip";
 type Props = {
   modalTitle: string;
   modalBody: ReactNode;
-  useTitleTooltip?: boolean; // not recommended
+  tooltipStyle?: "tooltipComponent" | "htmlTitle";
 };
 
 const Button = styled.a`
@@ -41,14 +41,18 @@ const Button = styled.a`
   }
 `;
 
-const OpenInFullscreenButton: FC<Props> = ({ modalTitle, modalBody, useTitleTooltip = false }) => {
+const OpenInFullscreenButton: FC<Props> = ({ modalTitle, modalBody, tooltipStyle = "tooltipComponent" }) => {
   const [t] = useTranslation("repos");
   const [showModal, setShowModal] = useState(false);
 
   const tooltip = t("diff.fullscreen.open");
   const content = (
     <>
-      <Button title={useTitleTooltip ? tooltip : undefined} className="button" onClick={() => setShowModal(true)}>
+      <Button
+        title={tooltipStyle === "htmlTitle" ? tooltip : undefined}
+        className="button"
+        onClick={() => setShowModal(true)}
+      >
         <i className="fas fa-search-plus" />
       </Button>
       {showModal && (
@@ -62,7 +66,7 @@ const OpenInFullscreenButton: FC<Props> = ({ modalTitle, modalBody, useTitleTool
     </>
   );
 
-  if (useTitleTooltip) {
+  if (tooltipStyle === "htmlTitle") {
     return <>{content}</>;
   }
   return (
diff --git a/scm-ui/ui-webapp/src/repos/sources/containers/Content.tsx b/scm-ui/ui-webapp/src/repos/sources/containers/Content.tsx
index 2f3ccfb3c0..03f2d6dc84 100644
--- a/scm-ui/ui-webapp/src/repos/sources/containers/Content.tsx
+++ b/scm-ui/ui-webapp/src/repos/sources/containers/Content.tsx
@@ -138,7 +138,7 @@ class Content extends React.Component<Props, State> {
             <OpenInFullscreenButton
               modalTitle={file?.name}
               modalBody={<BorderLessDiv className="panel">{content}</BorderLessDiv>}
-              useTitleTooltip={true}
+              tooltipStyle="htmlTitle"
             />
             <ExtensionPoint
               name="repos.sources.content.actionbar"