diff --git a/gradle/changelog/custom_permission_role.yaml b/gradle/changelog/custom_permission_role.yaml new file mode 100644 index 0000000000..0c8d2f347c --- /dev/null +++ b/gradle/changelog/custom_permission_role.yaml @@ -0,0 +1,2 @@ +- type: changed + description: Show "CUSTOM" name instead empty entry for permission roles ([#1597](https://github.com/scm-manager/scm-manager/pull/1597)) diff --git a/scm-ui/ui-webapp/src/repos/permissions/components/RoleSelector.tsx b/scm-ui/ui-webapp/src/repos/permissions/components/RoleSelector.tsx index 45bc9df4a8..cf497c37f5 100644 --- a/scm-ui/ui-webapp/src/repos/permissions/components/RoleSelector.tsx +++ b/scm-ui/ui-webapp/src/repos/permissions/components/RoleSelector.tsx @@ -31,11 +31,7 @@ type Props = { label?: string; helpText?: string; loading?: boolean; -}; - -const emptyOption = { - label: "", - value: "" + emptyLabel?: string; }; const createSelectOptions = (roles: string[]) => { @@ -47,11 +43,13 @@ const createSelectOptions = (roles: string[]) => { }); }; -const RoleSelector: FC = ({ availableRoles, role, handleRoleChange, loading, label, helpText }) => { +const RoleSelector: FC = ({ availableRoles, role, handleRoleChange, loading, label, helpText, emptyLabel }) => { if (!availableRoles) { return null; } - const options = role ? createSelectOptions(availableRoles) : [emptyOption, ...createSelectOptions(availableRoles)]; + const options = role + ? createSelectOptions(availableRoles) + : [{ label: emptyLabel || "", value: "" }, ...createSelectOptions(availableRoles)]; return (