diff --git a/scm-ui/src/repos/components/changesets/ChangesetDetails.js b/scm-ui/src/repos/components/changesets/ChangesetDetails.js index b93c72805b..26c3120bb8 100644 --- a/scm-ui/src/repos/components/changesets/ChangesetDetails.js +++ b/scm-ui/src/repos/components/changesets/ChangesetDetails.js @@ -12,6 +12,7 @@ import AvatarImage from "./AvatarImage"; import classNames from "classnames"; import ChangesetId from "./ChangesetId"; import type {Tag} from "@scm-manager/ui-types"; +import DiffView from "../../containers/DiffView"; const styles = { spacing: { @@ -70,6 +71,8 @@ class ChangesetDetails extends React.Component { ); })}

+ + ); } diff --git a/scm-ui/src/repos/containers/ScmDiff.js b/scm-ui/src/repos/containers/DiffView.js similarity index 52% rename from scm-ui/src/repos/containers/ScmDiff.js rename to scm-ui/src/repos/containers/DiffView.js index c1f82af512..cd26e74ee6 100644 --- a/scm-ui/src/repos/containers/ScmDiff.js +++ b/scm-ui/src/repos/containers/DiffView.js @@ -1,15 +1,12 @@ // @flow import React from "react"; -import { Diff, Hunk, parseDiff } from "react-diff-view"; import { apiClient } from "@scm-manager/ui-components"; -import type { Repository } from "@scm-manager/ui-types"; +import type { Changeset } from "@scm-manager/ui-types"; import { Diff2Html } from "diff2html"; type Props = { - //TODO: Actually, we want the Changeset here - repository: Repository, - revision: string, + changeset: Changeset, sideBySide: boolean }; @@ -25,9 +22,8 @@ class ScmDiff extends React.Component { } componentDidMount() { - const { repository, revision } = this.props; - const { namespace, name } = repository; - const url = `/repositories/${namespace}/${name}/diff/${revision}`; //TODO: use HATEOAS link from changeset + const { changeset } = this.props; + const url = changeset._links.diff.href; apiClient .get(url) .then(response => response.text()) @@ -49,25 +45,6 @@ class ScmDiff extends React.Component { // eslint-disable-next-line react/no-danger
); - // if (!this.state.diff) { - // return null; - // } - // - // const files = parseDiff(this.state.diff); - // - // const renderFile = ({ newPath, oldRevision, newRevision, type, hunks }) => ( - //
- //
File: {newPath}
- // - //
- // ); - // - // return
{files.map(renderFile)}
; } } diff --git a/scm-ui/src/repos/containers/RepositoryRoot.js b/scm-ui/src/repos/containers/RepositoryRoot.js index 99ab55441a..43171bce94 100644 --- a/scm-ui/src/repos/containers/RepositoryRoot.js +++ b/scm-ui/src/repos/containers/RepositoryRoot.js @@ -19,7 +19,6 @@ import EditNavLink from "../components/EditNavLink"; import BranchRoot from "./BranchRoot"; import ChangesetView from "./ChangesetView"; import PermissionsNavLink from "../components/PermissionsNavLink"; -import ScmDiff from "./ScmDiff"; type Props = { namespace: string, @@ -64,11 +63,6 @@ class RepositoryRoot extends React.Component { this.props.deleteRepo(repository, this.deleted); }; - matchChangeset = (route: any) => { - const url = this.matchedUrl(); - return route.location.pathname.match(`${url}/changeset/`); - }; - matches = (route: any) => { const url = this.matchedUrl(); const regex = new RegExp(`${url}(/branches)?/?[^/]*/changesets?.*`); @@ -141,16 +135,6 @@ class RepositoryRoot extends React.Component { /> )} /> - ( - - )} - />
@@ -173,9 +157,6 @@ class RepositoryRoot extends React.Component { -
- -