From da7d523f77f8fc1c8e03be7dad93aed1696985e1 Mon Sep 17 00:00:00 2001
From: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Date: Mon, 2 May 2022 14:10:57 +0200
Subject: [PATCH] Do not show feedback form for anonymous users

---
 gradle/changelog/feedback_anonymous.yaml |  2 ++
 scm-ui/ui-webapp/src/containers/App.tsx  | 12 ++++++------
 2 files changed, 8 insertions(+), 6 deletions(-)
 create mode 100644 gradle/changelog/feedback_anonymous.yaml

diff --git a/gradle/changelog/feedback_anonymous.yaml b/gradle/changelog/feedback_anonymous.yaml
new file mode 100644
index 0000000000..4d6faee779
--- /dev/null
+++ b/gradle/changelog/feedback_anonymous.yaml
@@ -0,0 +1,2 @@
+- type: fixed
+  description: Do not show feedback form for anonymous users
diff --git a/scm-ui/ui-webapp/src/containers/App.tsx b/scm-ui/ui-webapp/src/containers/App.tsx
index 35c61df543..def12cb8e1 100644
--- a/scm-ui/ui-webapp/src/containers/App.tsx
+++ b/scm-ui/ui-webapp/src/containers/App.tsx
@@ -48,26 +48,26 @@ const App: FC = () => {
 
   let content;
 
-  // authenticated means authorized, we stick on authenticated for compatibility reasons
-  const authenticated = isAuthenticated || isAnonymous;
+  // authenticatedOrAnonymous means authorized, we stick on authenticatedOrAnonymous for compatibility reasons
+  const authenticatedOrAnonymous = isAuthenticated || isAnonymous;
 
   if (index?.initialization) {
     const Extension = binder.getExtension(`initialization.step.${index.initialization}`);
     content = <Extension data={index?._embedded ? index._embedded[index.initialization] : undefined} />;
-  } else if (!authenticated && !isLoading) {
+  } else if (!authenticatedOrAnonymous && !isLoading) {
     content = <Login />;
   } else if (isLoading) {
     content = <Loading />;
   } else if (error) {
     content = <ErrorPage title={t("app.error.title")} subtitle={t("app.error.subtitle")} error={error} />;
   } else if (me) {
-    content = <Main authenticated={authenticated} me={me} links={index._links} />;
+    content = <Main authenticated={authenticatedOrAnonymous} me={me} links={index._links} />;
   }
 
   return (
     <AppWrapper className="App">
-      {authenticated ? <Feedback index={index} /> : null}
-      <Header authenticated={authenticated} links={index._links}>
+      {isAuthenticated ? <Feedback index={index} /> : null}
+      <Header authenticated={authenticatedOrAnonymous} links={index._links}>
         <NavigationBar links={index._links} />
       </Header>
       <div className="is-flex-grow-1">{content}</div>