From d3508af920be6bceae4ed5587a7d76b9b66d2c87 Mon Sep 17 00:00:00 2001 From: Florian Scholdei Date: Fri, 17 May 2019 15:47:20 +0200 Subject: [PATCH] add subtitle, missing props --- .../config/roles/containers/CreateRepositoryRole.js | 3 ++- .../src/config/roles/containers/EditRepositoryRole.js | 10 ++++++++-- 2 files changed, 10 insertions(+), 3 deletions(-) diff --git a/scm-ui/src/config/roles/containers/CreateRepositoryRole.js b/scm-ui/src/config/roles/containers/CreateRepositoryRole.js index 75380ada92..bef37f3603 100644 --- a/scm-ui/src/config/roles/containers/CreateRepositoryRole.js +++ b/scm-ui/src/config/roles/containers/CreateRepositoryRole.js @@ -3,7 +3,7 @@ import React from "react"; import RepositoryRoleForm from "./RepositoryRoleForm"; import { connect } from "react-redux"; import { translate } from "react-i18next"; -import { ErrorNotification, Title } from "@scm-manager/ui-components"; +import {ErrorNotification, Subtitle, Title} from "@scm-manager/ui-components"; import { createRole, getCreateRoleFailure, @@ -52,6 +52,7 @@ class CreateRepositoryRole extends React.Component { return ( <> + <Subtitle subtitle={t("repositoryRole.createSubtitle")} /> <RepositoryRoleForm disabled={this.props.disabled} submitForm={role => this.createRepositoryRole(role)} diff --git a/scm-ui/src/config/roles/containers/EditRepositoryRole.js b/scm-ui/src/config/roles/containers/EditRepositoryRole.js index deb0a77583..8bf1d5442b 100644 --- a/scm-ui/src/config/roles/containers/EditRepositoryRole.js +++ b/scm-ui/src/config/roles/containers/EditRepositoryRole.js @@ -8,8 +8,9 @@ import { isModifyRolePending, modifyRole } from "../modules/roles"; -import { ErrorNotification } from "@scm-manager/ui-components"; +import { ErrorNotification, Subtitle } from "@scm-manager/ui-components"; import type { RepositoryRole } from "@scm-manager/ui-types"; +import type { History } from "history"; type Props = { disabled: boolean, @@ -17,6 +18,10 @@ type Props = { repositoryRolesLink: string, error?: Error, + // context objects + t: string => string, + history: History, + //dispatch function updateRole: ( link: string, @@ -36,7 +41,7 @@ class EditRepositoryRole extends React.Component<Props> { }; render() { - const { error } = this.props; + const { error, t } = this.props; if (error) { return <ErrorNotification error={error} />; @@ -44,6 +49,7 @@ class EditRepositoryRole extends React.Component<Props> { return ( <> + <Subtitle subtitle={t("repositoryRole.editSubtitle")} /> <RepositoryRoleForm nameDisabled={true} role={this.props.role}