From d201c156f0fb927dd3efbf21448ec9d55214538a Mon Sep 17 00:00:00 2001
From: Mohamed Karray <mohamed.karray.sr@gmail.com>
Date: Tue, 29 Jan 2019 14:05:12 +0100
Subject: [PATCH] fix get modifications for SVN

---
 .../spi/SvnModificationsCommand.java          | 29 ++++++++++++++-----
 1 file changed, 21 insertions(+), 8 deletions(-)

diff --git a/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/repository/spi/SvnModificationsCommand.java b/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/repository/spi/SvnModificationsCommand.java
index 4b4f655b12..bbcaa9a9d5 100644
--- a/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/repository/spi/SvnModificationsCommand.java
+++ b/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/repository/spi/SvnModificationsCommand.java
@@ -4,6 +4,8 @@ import lombok.extern.slf4j.Slf4j;
 import org.tmatesoft.svn.core.SVNException;
 import org.tmatesoft.svn.core.SVNLogEntry;
 import org.tmatesoft.svn.core.io.SVNRepository;
+import org.tmatesoft.svn.core.wc.SVNClientManager;
+import org.tmatesoft.svn.core.wc.admin.SVNLookClient;
 import sonia.scm.repository.InternalRepositoryException;
 import sonia.scm.repository.Modifications;
 import sonia.scm.repository.Repository;
@@ -23,20 +25,31 @@ public class SvnModificationsCommand extends AbstractSvnCommand implements Modif
   @Override
   @SuppressWarnings("unchecked")
   public Modifications getModifications(String revision) {
-    Modifications modifications = null;
+    final Modifications modifications = new Modifications();
     log.debug("get modifications {}", revision);
     try {
-      long revisionNumber = SvnUtil.parseRevision(revision, repository);
-      SVNRepository repo = open();
-      Collection<SVNLogEntry> entries = repo.log(null, null, revisionNumber,
-        revisionNumber, true, true);
-      if (Util.isNotEmpty(entries)) {
-        modifications = SvnUtil.createModifications(entries.iterator().next(), revision);
+      if (SvnUtil.isTransactionEntryId(revision)) {
+
+        SVNLookClient client = SVNClientManager.newInstance().getLookClient();
+        client.doGetChanged(context.getDirectory(), SvnUtil.getTransactionId(revision),
+          e -> SvnUtil.appendModification(modifications, e.getType(), e.getPath()), true);
+
+        return modifications;
+
+      } else {
+
+        long revisionNumber = SvnUtil.getRevisionNumber(revision, repository);
+        SVNRepository repo = open();
+        Collection<SVNLogEntry> entries = repo.log(null, null, revisionNumber,
+          revisionNumber, true, true);
+        if (Util.isNotEmpty(entries)) {
+          return SvnUtil.createModifications(entries.iterator().next(), revision);
+        }
       }
     } catch (SVNException ex) {
       throw new InternalRepositoryException(repository, "could not open repository", ex);
     }
-    return modifications;
+    return null;
   }
 
   @Override