Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-02-22 06:26:56 +01:00
Code Issues Packages Projects Releases Activity

Mind review remarks

Browse Source
This commit is contained in:
René Pfeuffer
2020-10-06 15:42:26 +02:00
parent e512023d82
commit d03763671b
9 changed files with 79 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

10
scm-webapp/src/test/java/sonia/scm/security/ApiKeyTokenHandlerTest.java
View File

@@ -38,11 +38,9 @@ class ApiKeyTokenHandlerTest {
@Test
void shouldSerializeAndDeserializeToken() {
final String tokenString = handler.createToken("dent", new ApiKey("42", "hg2g", "READ", now()), "some secret");
String tokenString = handler.createToken("dent", new ApiKey("42", "hg2g", "READ", now()), "some secret");
System.out.println(tokenString);
final Optional<ApiKeyTokenHandler.Token> token = handler.readToken(tokenString);
Optional<ApiKeyTokenHandler.Token> token = handler.readToken(tokenString);
assertThat(token).isNotEmpty();
assertThat(token).get().extracting("user").isEqualTo("dent");
@@ -52,14 +50,14 @@ class ApiKeyTokenHandlerTest {
@Test
void shouldNotFailWithInvalidTokenEncoding() {
final Optional<ApiKeyTokenHandler.Token> token = handler.readToken("invalid token");
Optional<ApiKeyTokenHandler.Token> token = handler.readToken("invalid token");
assertThat(token).isEmpty();
}
@Test
void shouldNotFailWithInvalidTokenContent() {
final Optional<ApiKeyTokenHandler.Token> token = handler.readToken(Encoders.BASE64URL.encode("{\"invalid\":\"token\"}".getBytes()));
Optional<ApiKeyTokenHandler.Token> token = handler.readToken(Encoders.BASE64URL.encode("{\"invalid\":\"token\"}".getBytes()));
assertThat(token).isEmpty();
}

2
scm-webapp/src/test/java/sonia/scm/security/ScopesTest.java
View File

@@ -71,7 +71,7 @@ public class ScopesTest {
}
@Test
public void testFilterX() {
public void testFilterIntersectingPermissions() {
Scope scope = Scope.valueOf("repository:read,write:*");
AuthorizationInfo authz = authz("repository:*:123");