From bd8a5c679bd15c9948ad6aecff31e4b07642c2d8 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Sat, 21 Mar 2015 15:51:08 +0100 Subject: [PATCH] do not create a httpsession for logging --- .../sonia/scm/web/filter/LoggingFilter.java | 25 +++++++++++-------- 1 file changed, 14 insertions(+), 11 deletions(-) diff --git a/scm-core/src/main/java/sonia/scm/web/filter/LoggingFilter.java b/scm-core/src/main/java/sonia/scm/web/filter/LoggingFilter.java index 8af72bfa5d..7bf52ac300 100644 --- a/scm-core/src/main/java/sonia/scm/web/filter/LoggingFilter.java +++ b/scm-core/src/main/java/sonia/scm/web/filter/LoggingFilter.java @@ -173,20 +173,23 @@ public class LoggingFilter extends HttpFilter } } - HttpSession session = request.getSession(true); + HttpSession session = request.getSession(false); - logger.debug("Session-New: {}", Boolean.toString(session.isNew())); - - Enumeration sAttributes = session.getAttributeNames(); - - if (sAttributes != null) + if (session != null) { - while (sAttributes.hasMoreElements()) - { - String sAttribute = (String) sAttributes.nextElement(); + logger.debug("Session-New: {}", Boolean.toString(session.isNew())); - logger.debug("Session-Attribute: {} = {}", sAttribute, - request.getSession().getAttribute(sAttribute).toString()); + Enumeration sAttributes = session.getAttributeNames(); + + if (sAttributes != null) + { + while (sAttributes.hasMoreElements()) + { + String sAttribute = (String) sAttributes.nextElement(); + + logger.debug("Session-Attribute: {} = {}", sAttribute, + request.getSession().getAttribute(sAttribute).toString()); + } } }