From bb6f076178afbffed3259466e3639bf20b400ed6 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Maren=20S=C3=BCwer?= Date: Mon, 13 Aug 2018 08:43:13 +0200 Subject: [PATCH] add selectors for modifyGroupPending and Failure --- scm-ui/src/config/modules/config.js | 8 ++++++ scm-ui/src/config/modules/config.test.js | 31 +++++++++++++++++++++++- 2 files changed, 38 insertions(+), 1 deletion(-) diff --git a/scm-ui/src/config/modules/config.js b/scm-ui/src/config/modules/config.js index df04e53235..0c231ea1ac 100644 --- a/scm-ui/src/config/modules/config.js +++ b/scm-ui/src/config/modules/config.js @@ -134,6 +134,14 @@ export function getFetchConfigFailure(state: Object) { return getFailure(state, FETCH_CONFIG); } +export function isModifyConfigPending(state: Object) { + return isPending(state, MODIFY_CONFIG); +} + +export function getModifyConfigFailure(state: Object) { + return getFailure(state, MODIFY_CONFIG); +} + export function getConfig(state: Object) { if (state.config && state.config.entries) { return state.config.entries; diff --git a/scm-ui/src/config/modules/config.test.js b/scm-ui/src/config/modules/config.test.js index 76f8f1a2b2..78b19f10c7 100644 --- a/scm-ui/src/config/modules/config.test.js +++ b/scm-ui/src/config/modules/config.test.js @@ -8,6 +8,7 @@ import reducer, { FETCH_CONFIG_PENDING, FETCH_CONFIG_SUCCESS, FETCH_CONFIG_FAILURE, + MODIFY_CONFIG, MODIFY_CONFIG_PENDING, MODIFY_CONFIG_SUCCESS, MODIFY_CONFIG_FAILURE, @@ -16,6 +17,8 @@ import reducer, { getFetchConfigFailure, isFetchConfigPending, modifyConfig, + isModifyConfigPending, + getModifyConfigFailure, getConfig, getConfigUpdatePermission } from "./config"; @@ -200,6 +203,32 @@ describe("selector tests", () => { expect(getFetchConfigFailure({})).toBe(undefined); }); + it("should return true, when modify group is pending", () => { + const state = { + pending: { + [MODIFY_CONFIG]: true + } + }; + expect(isModifyConfigPending(state)).toEqual(true); + }); + + it("should return false, when modify config is not pending", () => { + expect(isModifyConfigPending({})).toEqual(false); + }); + + it("should return error when modify config did fail", () => { + const state = { + failure: { + [MODIFY_CONFIG]: error + } + }; + expect(getModifyConfigFailure(state)).toEqual(error); + }); + + it("should return undefined when modify config did not fail", () => { + expect(getModifyConfigFailure({})).toBe(undefined); + }); + it("should return config", () => { const state = { config: { @@ -209,7 +238,7 @@ describe("selector tests", () => { expect(getConfig(state)).toEqual(config); }); - it("should return configUpdatePermission", () => { + it("should return configUpdatePermission", () => { const state = { config: { configUpdatePermission: true