From ba71621aae83616bb34bf896289aac1096ce7d0f Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Pfeuffer?= Date: Tue, 4 Dec 2018 13:01:17 +0100 Subject: [PATCH] Suppress Sonar issue Found no way to extract these internal classes into external classes without loosing type information, so that the created stores were no longer type safe. --- .../java/sonia/scm/store/ConfigurationEntryStoreFactory.java | 1 + .../src/main/java/sonia/scm/store/ConfigurationStoreFactory.java | 1 + scm-core/src/main/java/sonia/scm/store/DataStoreFactory.java | 1 + 3 files changed, 3 insertions(+) diff --git a/scm-core/src/main/java/sonia/scm/store/ConfigurationEntryStoreFactory.java b/scm-core/src/main/java/sonia/scm/store/ConfigurationEntryStoreFactory.java index 80f9cb3df9..a47afaa176 100644 --- a/scm-core/src/main/java/sonia/scm/store/ConfigurationEntryStoreFactory.java +++ b/scm-core/src/main/java/sonia/scm/store/ConfigurationEntryStoreFactory.java @@ -85,6 +85,7 @@ public interface ConfigurationEntryStoreFactory { } } +@SuppressWarnings("common-java:DuplicatedBlocks") final class TypedFloatingConfigurationEntryStoreParameters { private final TypedStoreParametersImpl parameters = new TypedStoreParametersImpl<>(); diff --git a/scm-core/src/main/java/sonia/scm/store/ConfigurationStoreFactory.java b/scm-core/src/main/java/sonia/scm/store/ConfigurationStoreFactory.java index 6624f307e7..568fb1f1de 100644 --- a/scm-core/src/main/java/sonia/scm/store/ConfigurationStoreFactory.java +++ b/scm-core/src/main/java/sonia/scm/store/ConfigurationStoreFactory.java @@ -85,6 +85,7 @@ public interface ConfigurationStoreFactory { } } +@SuppressWarnings("common-java:DuplicatedBlocks") final class TypedFloatingConfigurationStoreParameters { private final TypedStoreParametersImpl parameters = new TypedStoreParametersImpl<>(); diff --git a/scm-core/src/main/java/sonia/scm/store/DataStoreFactory.java b/scm-core/src/main/java/sonia/scm/store/DataStoreFactory.java index 564c339d3d..8326fa40a4 100644 --- a/scm-core/src/main/java/sonia/scm/store/DataStoreFactory.java +++ b/scm-core/src/main/java/sonia/scm/store/DataStoreFactory.java @@ -82,6 +82,7 @@ public interface DataStoreFactory { } } +@SuppressWarnings("common-java:DuplicatedBlocks") final class TypedFloatingDataStoreParameters { private final TypedStoreParametersImpl parameters = new TypedStoreParametersImpl<>();