From b850ab9fa81b29e7a131f4a0ded981c8c006d251 Mon Sep 17 00:00:00 2001 From: Philipp Czora Date: Fri, 15 Feb 2019 17:44:35 +0100 Subject: [PATCH] Invalidate form when scope (group/user) is switched --- .../permissions/containers/CreatePermissionForm.js | 11 ++++------- 1 file changed, 4 insertions(+), 7 deletions(-) diff --git a/scm-ui/src/repos/permissions/containers/CreatePermissionForm.js b/scm-ui/src/repos/permissions/containers/CreatePermissionForm.js index 989079c717..2f67b3df92 100644 --- a/scm-ui/src/repos/permissions/containers/CreatePermissionForm.js +++ b/scm-ui/src/repos/permissions/containers/CreatePermissionForm.js @@ -55,14 +55,11 @@ class CreatePermissionForm extends React.Component { permissionScopeChanged = event => { const groupPermission = event.target.value === "GROUP_PERMISSION"; this.setState({ + value: undefined, + name: "", groupPermission: groupPermission, - valid: validator.isPermissionValid( - this.state.name, - groupPermission, - this.props.currentPermissions - ) + valid: false }); - this.setState({ ...this.state, groupPermission, value: undefined}); }; loadUserAutocompletion = (inputValue: string) => { @@ -245,7 +242,7 @@ class CreatePermissionForm extends React.Component { }; removeState = () => { - this.setState({...this.state, + this.setState({ name: "", verbs: this.props.availablePermissions.availableRoles[0].verbs, valid: true,