From 57721a8a447a8bd604c188f666459a47af87339a Mon Sep 17 00:00:00 2001
From: Florian Scholdei <florian.scholdei@cloudogu.com>
Date: Tue, 16 Apr 2019 15:16:36 +0200
Subject: [PATCH 1/2] fixed borders, colours, styling in sources, users, groups
 and me detail view

---
 scm-ui/src/containers/ProfileInfo.js          |  12 +-
 .../repos/components/RepositoryDetailTable.js | 110 +++++++++---------
 scm-ui/src/users/components/table/Details.js  |  14 +--
 scm-ui/styles/scm.scss                        |   2 +-
 4 files changed, 66 insertions(+), 72 deletions(-)

diff --git a/scm-ui/src/containers/ProfileInfo.js b/scm-ui/src/containers/ProfileInfo.js
index ab8eacae0e..a861524c80 100644
--- a/scm-ui/src/containers/ProfileInfo.js
+++ b/scm-ui/src/containers/ProfileInfo.js
@@ -40,21 +40,15 @@ class ProfileInfo extends React.Component<Props> {
           <table className="table content">
             <tbody>
               <tr>
-                <th>
-                  {t("profile.username")}
-                </th>
+                <th>{t("profile.username")}</th>
                 <td>{me.name}</td>
               </tr>
               <tr>
-                <th>
-                  {t("profile.displayName")}
-                </th>
+                <th>{t("profile.displayName")}</th>
                 <td>{me.displayName}</td>
               </tr>
               <tr>
-                <th>
-                  {t("profile.mail")}
-                </th>
+                <th>{t("profile.mail")}</th>
                 <td>
                   <MailLink address={me.mail} />
                 </td>
diff --git a/scm-ui/src/repos/components/RepositoryDetailTable.js b/scm-ui/src/repos/components/RepositoryDetailTable.js
index ca63398670..a59ed254ef 100644
--- a/scm-ui/src/repos/components/RepositoryDetailTable.js
+++ b/scm-ui/src/repos/components/RepositoryDetailTable.js
@@ -1,55 +1,55 @@
-//@flow
-import React from "react";
-import type { Repository } from "@scm-manager/ui-types";
-import { MailLink, DateFromNow } from "@scm-manager/ui-components";
-import { translate } from "react-i18next";
-
-type Props = {
-  repository: Repository,
-  // context props
-  t: string => string
-};
-
-class RepositoryDetailTable extends React.Component<Props> {
-  render() {
-    const { repository, t } = this.props;
-    return (
-      <table className="table">
-        <tbody>
-          <tr>
-            <td className="has-text-weight-semibold">{t("repository.name")}</td>
-            <td>{repository.name}</td>
-          </tr>
-          <tr>
-            <td className="has-text-weight-semibold">{t("repository.type")}</td>
-            <td>{repository.type}</td>
-          </tr>
-          <tr>
-            <td className="has-text-weight-semibold">{t("repository.contact")}</td>
-            <td>
-              <MailLink address={repository.contact} />
-            </td>
-          </tr>
-          <tr>
-            <td className="has-text-weight-semibold">{t("repository.description")}</td>
-            <td>{repository.description}</td>
-          </tr>
-          <tr>
-            <td className="has-text-weight-semibold">{t("repository.creationDate")}</td>
-            <td>
-              <DateFromNow date={repository.creationDate} />
-            </td>
-          </tr>
-          <tr>
-            <td className="has-text-weight-semibold">{t("repository.lastModified")}</td>
-            <td>
-              <DateFromNow date={repository.lastModified} />
-            </td>
-          </tr>
-        </tbody>
-      </table>
-    );
-  }
-}
-
-export default translate("repos")(RepositoryDetailTable);
+//@flow
+import React from "react";
+import type { Repository } from "@scm-manager/ui-types";
+import { MailLink, DateFromNow } from "@scm-manager/ui-components";
+import { translate } from "react-i18next";
+
+type Props = {
+  repository: Repository,
+  // context props
+  t: string => string
+};
+
+class RepositoryDetailTable extends React.Component<Props> {
+  render() {
+    const { repository, t } = this.props;
+    return (
+      <table className="table">
+        <tbody>
+          <tr>
+            <th>{t("repository.name")}</th>
+            <td>{repository.name}</td>
+          </tr>
+          <tr>
+            <th>{t("repository.type")}</th>
+            <td>{repository.type}</td>
+          </tr>
+          <tr>
+            <th>{t("repository.contact")}</th>
+            <td>
+              <MailLink address={repository.contact} />
+            </td>
+          </tr>
+          <tr>
+            <th>{t("repository.description")}</th>
+            <td>{repository.description}</td>
+          </tr>
+          <tr>
+            <th>{t("repository.creationDate")}</th>
+            <td>
+              <DateFromNow date={repository.creationDate} />
+            </td>
+          </tr>
+          <tr>
+            <th>{t("repository.lastModified")}</th>
+            <td>
+              <DateFromNow date={repository.lastModified} />
+            </td>
+          </tr>
+        </tbody>
+      </table>
+    );
+  }
+}
+
+export default translate("repos")(RepositoryDetailTable);
diff --git a/scm-ui/src/users/components/table/Details.js b/scm-ui/src/users/components/table/Details.js
index 83eebccc08..2195ec4665 100644
--- a/scm-ui/src/users/components/table/Details.js
+++ b/scm-ui/src/users/components/table/Details.js
@@ -16,37 +16,37 @@ class Details extends React.Component<Props> {
       <table className="table">
         <tbody>
           <tr>
-            <td className="has-text-weight-semibold">{t("user.name")}</td>
+            <th>{t("user.name")}</th>
             <td>{user.name}</td>
           </tr>
           <tr>
-            <td className="has-text-weight-semibold">{t("user.displayName")}</td>
+            <th>{t("user.displayName")}</th>
             <td>{user.displayName}</td>
           </tr>
           <tr>
-            <td className="has-text-weight-semibold">{t("user.mail")}</td>
+            <th>{t("user.mail")}</th>
             <td>
               <MailLink address={user.mail} />
             </td>
           </tr>
           <tr>
-            <td className="has-text-weight-semibold">{t("user.active")}</td>
+            <th>{t("user.active")}</th>
             <td>
               <Checkbox checked={user.active} />
             </td>
           </tr>
           <tr>
-            <td className="has-text-weight-semibold">{t("user.type")}</td>
+            <th>{t("user.type")}</th>
             <td>{user.type}</td>
           </tr>
           <tr>
-            <td className="has-text-weight-semibold">{t("user.creationDate")}</td>
+            <th>{t("user.creationDate")}</th>
             <td>
               <DateFromNow date={user.creationDate} />
             </td>
           </tr>
           <tr>
-            <td className="has-text-weight-semibold">{t("user.lastModified")}</td>
+            <th>{t("user.lastModified")}</th>
             <td>
               <DateFromNow date={user.lastModified} />
             </td>
diff --git a/scm-ui/styles/scm.scss b/scm-ui/styles/scm.scss
index e02a4b28e0..c1b4fdb6de 100644
--- a/scm-ui/styles/scm.scss
+++ b/scm-ui/styles/scm.scss
@@ -165,7 +165,7 @@ $fa-font-path: "webfonts";
 // tables
 .table {
   width: 100%;
-  td {
+  td, th {
     border-color: #eee;
     padding: 1rem;
   }

From d11cb8ce37f383b181ac2416ce9e981b630b71e4 Mon Sep 17 00:00:00 2001
From: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
Date: Thu, 18 Apr 2019 06:08:41 +0000
Subject: [PATCH 2/2] Close branch feature/css_fix_table_styling