From b536a7b318710bc7ae152766ebdfe5f8a8d8e999 Mon Sep 17 00:00:00 2001
From: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
Date: Sat, 20 Dec 2014 23:51:46 +0100
Subject: [PATCH] fix some unchecked warnings

---
 .../sonia/scm/plugin/ExtensionProcessor.java  | 24 +++++++++++--------
 .../test/java/sonia/scm/PrioritiesTest.java   | 12 ++++++----
 .../scm/plugin/DefaultExtensionProcessor.java |  1 +
 3 files changed, 22 insertions(+), 15 deletions(-)

diff --git a/scm-core/src/main/java/sonia/scm/plugin/ExtensionProcessor.java b/scm-core/src/main/java/sonia/scm/plugin/ExtensionProcessor.java
index 90221db055..80ad42642d 100644
--- a/scm-core/src/main/java/sonia/scm/plugin/ExtensionProcessor.java
+++ b/scm-core/src/main/java/sonia/scm/plugin/ExtensionProcessor.java
@@ -45,28 +45,32 @@ public interface ExtensionProcessor
 {
 
   /**
-   * Return extensions
+   * Collect extension classes by extension point.
    *
    *
-   * @param extensionPoint
-   * @return
+   * @param <T> type of extension
+   * @param extensionPoint extension point
+   * 
+   * @return extensions
    */
-  public Iterable<Class> byExtensionPoint(Class extensionPoint);
+  public <T> Iterable<Class<T>> byExtensionPoint(Class<T> extensionPoint);
 
   /**
-   * Method description
+   * Returns single extension by its extension point.
    *
    *
-   * @param extensionPoint
-   * @return
+   * @param <T> type of extension
+   * @param extensionPoint extension point
+   * 
+   * @return extension
    */
-  public Class oneByExtensionPoint(Class extensionPoint);
+  public <T> Class<T> oneByExtensionPoint(Class<T> extensionPoint);
 
   /**
-   * Method description
+   * Process auto bind extensions.
    *
    *
-   * @param binder
+   * @param binder injection binder
    */
   public void processAutoBindExtensions(Binder binder);
 }
diff --git a/scm-core/src/test/java/sonia/scm/PrioritiesTest.java b/scm-core/src/test/java/sonia/scm/PrioritiesTest.java
index a73a3278d7..09be1b0980 100644
--- a/scm-core/src/test/java/sonia/scm/PrioritiesTest.java
+++ b/scm-core/src/test/java/sonia/scm/PrioritiesTest.java
@@ -69,7 +69,8 @@ public class PrioritiesTest
   @Test
   public void testGetPriority()
   {
-    assertEquals(Priorities.POST_AUTHENTICATION, Priorities.getPriority(A.class));
+    assertEquals(Priorities.POST_AUTHENTICATION,
+      Priorities.getPriority(A.class));
     assertEquals(Priorities.DEFAULT, Priorities.getPriority(D.class));
   }
 
@@ -78,6 +79,7 @@ public class PrioritiesTest
    *
    */
   @Test
+  @SuppressWarnings("unchecked")
   public void testSort()
   {
     List<Class<?>> cls = ImmutableList.of(A.class, B.class, C.class, D.class);
@@ -93,7 +95,7 @@ public class PrioritiesTest
    *
    *
    * @version        Enter version here..., 14/12/20
-   * @author         Enter your name here...    
+   * @author         Enter your name here...
    */
   @Priority(Priorities.POST_AUTHENTICATION)
   public static class A {}
@@ -104,7 +106,7 @@ public class PrioritiesTest
    *
    *
    * @version        Enter version here..., 14/12/20
-   * @author         Enter your name here...    
+   * @author         Enter your name here...
    */
   @Priority(Priorities.PRE_AUTHENTICATION)
   public static class B {}
@@ -115,7 +117,7 @@ public class PrioritiesTest
    *
    *
    * @version        Enter version here..., 14/12/20
-   * @author         Enter your name here...    
+   * @author         Enter your name here...
    */
   @Priority(Priorities.AUTHENTICATION)
   public static class C {}
@@ -126,7 +128,7 @@ public class PrioritiesTest
    *
    *
    * @version        Enter version here..., 14/12/20
-   * @author         Enter your name here...    
+   * @author         Enter your name here...
    */
   public static class D {}
 }
diff --git a/scm-webapp/src/main/java/sonia/scm/plugin/DefaultExtensionProcessor.java b/scm-webapp/src/main/java/sonia/scm/plugin/DefaultExtensionProcessor.java
index 46f13bb1a7..4c2ef8767d 100644
--- a/scm-webapp/src/main/java/sonia/scm/plugin/DefaultExtensionProcessor.java
+++ b/scm-webapp/src/main/java/sonia/scm/plugin/DefaultExtensionProcessor.java
@@ -43,6 +43,7 @@ import org.slf4j.LoggerFactory;
  *
  * @author Sebastian Sdorra
  */
+@SuppressWarnings("unchecked")
 public class DefaultExtensionProcessor implements ExtensionProcessor
 {