From b4c78a24110ab8607376588970a61de3e3ac91e9 Mon Sep 17 00:00:00 2001
From: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
Date: Tue, 12 Oct 2010 16:07:15 +0200
Subject: [PATCH] fix bug in AbstractSimpleRepositoryHandler

---
 .../AbstractSimpleRepositoryHandler.java      | 42 +++++++++++++++----
 1 file changed, 35 insertions(+), 7 deletions(-)

diff --git a/scm-core/src/main/java/sonia/scm/repository/AbstractSimpleRepositoryHandler.java b/scm-core/src/main/java/sonia/scm/repository/AbstractSimpleRepositoryHandler.java
index 023222c429..ce125fac12 100644
--- a/scm-core/src/main/java/sonia/scm/repository/AbstractSimpleRepositoryHandler.java
+++ b/scm-core/src/main/java/sonia/scm/repository/AbstractSimpleRepositoryHandler.java
@@ -13,7 +13,7 @@ import sonia.scm.ConfigurationException;
 import sonia.scm.SCMContextProvider;
 import sonia.scm.io.CommandResult;
 import sonia.scm.io.ExtendedCommand;
-import sonia.scm.util.Util;
+import sonia.scm.util.IOUtil;
 
 //~--- JDK imports ------------------------------------------------------------
 
@@ -28,7 +28,6 @@ import java.util.logging.Level;
 import java.util.logging.Logger;
 
 import javax.xml.bind.JAXB;
-import sonia.scm.util.IOUtil;
 
 /**
  *
@@ -195,12 +194,12 @@ public abstract class AbstractSimpleRepositoryHandler<T extends SimpleRepository
   @Override
   public Repository get(String id)
   {
-    Repository repository = null;
     File repositoryFile = getRepositoryFile(id);
+    Repository repository = null;
 
     if (repositoryFile.exists())
     {
-      repository = JAXB.unmarshal(repositoryFile, Repository.class);
+      repository = getRepositoryFromConfig(repositoryFile);
     }
 
     return repository;
@@ -229,10 +228,12 @@ public abstract class AbstractSimpleRepositoryHandler<T extends SimpleRepository
     {
       try
       {
-        Repository repository = JAXB.unmarshal(repositoryFile,
-                                  Repository.class);
+        Repository repository = getRepositoryFromConfig(repositoryFile);
 
-        repositories.add(repository);
+        if (repository != null)
+        {
+          repositories.add(repository);
+        }
       }
       catch (Exception ex)
       {
@@ -316,6 +317,33 @@ public abstract class AbstractSimpleRepositoryHandler<T extends SimpleRepository
     return directory;
   }
 
+  /**
+   * Method description
+   *
+   *
+   * @param repositoryFile
+   *
+   * @return
+   */
+  protected Repository getRepositoryFromConfig(File repositoryFile)
+  {
+    Repository repository = JAXB.unmarshal(repositoryFile, Repository.class);
+    File directory = getDirectory(repository);
+
+    if (!directory.exists())
+    {
+      if (logger.isLoggable(Level.WARNING))
+      {
+        logger.warning(
+            "could not find repository ".concat(repository.getName()));
+      }
+
+      repository = null;
+    }
+
+    return repository;
+  }
+
   /**
    * Method description
    *