From b05cf39df853d8e40204beb462ebc1b7a4a9e227 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Tue, 28 Jan 2014 21:34:31 +0100 Subject: [PATCH] fix possible concurrent modification exception --- scm-dao-xml/src/main/java/sonia/scm/xml/AbstractXmlDAO.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scm-dao-xml/src/main/java/sonia/scm/xml/AbstractXmlDAO.java b/scm-dao-xml/src/main/java/sonia/scm/xml/AbstractXmlDAO.java index 33765ce8a0..a0baa41034 100644 --- a/scm-dao-xml/src/main/java/sonia/scm/xml/AbstractXmlDAO.java +++ b/scm-dao-xml/src/main/java/sonia/scm/xml/AbstractXmlDAO.java @@ -34,6 +34,7 @@ package sonia.scm.xml; //~--- non-JDK imports -------------------------------------------------------- +import com.google.common.collect.ImmutableList; import org.slf4j.Logger; import org.slf4j.LoggerFactory; @@ -229,7 +230,8 @@ public abstract class AbstractXmlDAO getAll() { - return db.values(); + // avoid concurrent modification exceptions + return ImmutableList.copyOf(db.values()); } /**