From afd4b06b618ca1ffb8eeb0bf2b23e3a007d363ea Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Pfeuffer?= Date: Wed, 27 Jun 2018 15:00:52 +0200 Subject: [PATCH] Remove not used functions Equals and hashCode are not used, yet. Therefore we have no idea, how they should be implemented at all. So they should not be implemented, yet. Further they are polluting the test coverage. --- .../java/sonia/scm/api/v2/resources/CollectionDto.java | 6 +++--- .../main/java/sonia/scm/api/v2/resources/GroupDto.java | 6 +++--- .../main/java/sonia/scm/api/v2/resources/MemberDto.java | 7 +++---- .../src/main/java/sonia/scm/api/v2/resources/UserDto.java | 8 +++----- 4 files changed, 12 insertions(+), 15 deletions(-) diff --git a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/CollectionDto.java b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/CollectionDto.java index 8a030e5070..c10e18267c 100644 --- a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/CollectionDto.java +++ b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/CollectionDto.java @@ -3,10 +3,10 @@ package sonia.scm.api.v2.resources; import de.otto.edison.hal.Embedded; import de.otto.edison.hal.HalRepresentation; import de.otto.edison.hal.Links; -import lombok.Data; -import lombok.EqualsAndHashCode; +import lombok.Getter; +import lombok.Setter; -@Data @EqualsAndHashCode(callSuper = false) +@Getter @Setter class CollectionDto extends HalRepresentation { private int page; diff --git a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/GroupDto.java b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/GroupDto.java index 65dae5f5f1..081ae817ae 100644 --- a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/GroupDto.java +++ b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/GroupDto.java @@ -3,16 +3,16 @@ package sonia.scm.api.v2.resources; import com.fasterxml.jackson.annotation.JsonInclude; import de.otto.edison.hal.HalRepresentation; import de.otto.edison.hal.Links; -import lombok.Data; -import lombok.EqualsAndHashCode; +import lombok.Getter; import lombok.NoArgsConstructor; +import lombok.Setter; import java.time.Instant; import java.util.List; import java.util.Map; import java.util.Optional; -@Data @NoArgsConstructor @EqualsAndHashCode(callSuper = true) +@Getter @Setter @NoArgsConstructor public class GroupDto extends HalRepresentation { private Instant creationDate; diff --git a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/MemberDto.java b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/MemberDto.java index fcd7b8e8ad..dd4979bb4b 100644 --- a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/MemberDto.java +++ b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/MemberDto.java @@ -3,12 +3,11 @@ package sonia.scm.api.v2.resources; import de.otto.edison.hal.HalRepresentation; import de.otto.edison.hal.Links; import lombok.AllArgsConstructor; -import lombok.Data; -import lombok.EqualsAndHashCode; +import lombok.Getter; import lombok.NoArgsConstructor; +import lombok.Setter; -@NoArgsConstructor @AllArgsConstructor -@Data @EqualsAndHashCode(callSuper = false) +@NoArgsConstructor @AllArgsConstructor @Getter @Setter public class MemberDto extends HalRepresentation { private String name; diff --git a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/UserDto.java b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/UserDto.java index 3a5b1271fd..d87f4a74f1 100644 --- a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/UserDto.java +++ b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/UserDto.java @@ -3,17 +3,15 @@ package sonia.scm.api.v2.resources; import com.fasterxml.jackson.annotation.JsonInclude; import de.otto.edison.hal.HalRepresentation; import de.otto.edison.hal.Links; -import lombok.AllArgsConstructor; -import lombok.Data; -import lombok.EqualsAndHashCode; +import lombok.Getter; import lombok.NoArgsConstructor; +import lombok.Setter; import java.time.Instant; import java.util.Map; import java.util.Optional; -@AllArgsConstructor @NoArgsConstructor -@Data @EqualsAndHashCode(callSuper = false) +@NoArgsConstructor @Getter @Setter public class UserDto extends HalRepresentation { private boolean active; private boolean admin;