diff --git a/gradle/changelog/file_search.yaml b/gradle/changelog/file_search.yaml new file mode 100644 index 0000000000..453b1452c0 --- /dev/null +++ b/gradle/changelog/file_search.yaml @@ -0,0 +1,2 @@ +- type: Fixed + description: Fix file search on branches with "/" ([#1748](https://github.com/scm-manager/scm-manager/pull/1748)) diff --git a/scm-ui/ui-webapp/src/repos/codeSection/components/FileSearchButton.tsx b/scm-ui/ui-webapp/src/repos/codeSection/components/FileSearchButton.tsx index a215bb7381..efe4cfbe42 100644 --- a/scm-ui/ui-webapp/src/repos/codeSection/components/FileSearchButton.tsx +++ b/scm-ui/ui-webapp/src/repos/codeSection/components/FileSearchButton.tsx @@ -39,7 +39,7 @@ const SearchIcon = styled(Icon)` const FileSearchButton: FC = ({ baseUrl, revision }) => { const [t] = useTranslation("repos"); return ( - + ); diff --git a/scm-ui/ui-webapp/src/repos/codeSection/containers/FileSearch.tsx b/scm-ui/ui-webapp/src/repos/codeSection/containers/FileSearch.tsx index c446cbd767..86cac4ebd2 100644 --- a/scm-ui/ui-webapp/src/repos/codeSection/containers/FileSearch.tsx +++ b/scm-ui/ui-webapp/src/repos/codeSection/containers/FileSearch.tsx @@ -23,13 +23,12 @@ */ import React, { FC, useEffect, useState } from "react"; import { Branch, Repository } from "@scm-manager/ui-types"; -import { useHistory, useLocation, useParams } from "react-router-dom"; +import { Link, useHistory, useLocation, useParams } from "react-router-dom"; import { urls, usePaths } from "@scm-manager/ui-api"; import { ErrorNotification, FilterInput, Help, Icon, Loading } from "@scm-manager/ui-components"; import CodeActionBar from "../components/CodeActionBar"; import styled from "styled-components"; import FileSearchResults from "../components/FileSearchResults"; -import { Link } from "react-router-dom"; import { useTranslation } from "react-i18next"; import { filepathSearch } from "../utils/filepathSearch"; @@ -67,7 +66,7 @@ const SearchHelp = styled(Help)` const useRevision = () => { const { revision } = useParams(); - return decodeURIComponent(revision); + return revision; }; const FileSearch: FC = ({ repository, baseUrl, branches, selectedBranch }) => { @@ -98,12 +97,12 @@ const FileSearch: FC = ({ repository, baseUrl, branches, selectedBranch } const evaluateSwitchViewLink = (type: string) => { if (type === "sources") { - return `${baseUrl}/sources/${encodeURIComponent(revision)}/`; + return `${baseUrl}/sources/${revision}/`; } - return `${baseUrl}/changesets/${encodeURIComponent(revision)}/`; + return `${baseUrl}/changesets/${revision}/`; }; - const contentBaseUrl = `${baseUrl}/sources/${encodeURIComponent(revision)}/`; + const contentBaseUrl = `${baseUrl}/sources/${revision}/`; return ( <>