From ac3821ad6d82dafb40c8ea1ba9d147cef70e21ca Mon Sep 17 00:00:00 2001
From: Rene Pfeuffer <rene.pfeuffer@cloudogu.com>
Date: Thu, 16 Jan 2020 13:05:44 +0100
Subject: [PATCH] Hide 'side by side' button when there is no diff

---
 scm-ui/ui-components/src/repos/DiffFile.tsx | 28 ++++++++++++---------
 1 file changed, 16 insertions(+), 12 deletions(-)

diff --git a/scm-ui/ui-components/src/repos/DiffFile.tsx b/scm-ui/ui-components/src/repos/DiffFile.tsx
index 7272febede..49da9b2484 100644
--- a/scm-ui/ui-components/src/repos/DiffFile.tsx
+++ b/scm-ui/ui-components/src/repos/DiffFile.tsx
@@ -271,8 +271,22 @@ class DiffFile extends React.Component<Props, State> {
       );
     }
     const collapseIcon = this.hasContent(file) ? <Icon name={icon} color="inherit" /> : null;
-
     const fileControls = fileControlFactory ? fileControlFactory(file, this.setCollapse) : null;
+    const sideBySideToggle =
+      file.hunks && file.hunks.length > 0 ? (
+        <ButtonWrapper className={classNames("level-right", "is-flex")}>
+          <ButtonGroup>
+            <Button
+              action={this.toggleSideBySide}
+              icon={sideBySide ? "align-left" : "columns"}
+              label={t(sideBySide ? "diff.combined" : "diff.sideBySide")}
+              reducedMobile={true}
+            />
+            {fileControls}
+          </ButtonGroup>
+        </ButtonWrapper>
+      ) : null;
+
     return (
       <DiffFilePanel className={classNames("panel", "is-size-6")} collapsed={(file && file.isBinary) || collapsed}>
         <div className="panel-heading">
@@ -288,17 +302,7 @@ class DiffFile extends React.Component<Props, State> {
               </TitleWrapper>
               {this.renderChangeTag(file)}
             </FullWidthTitleHeader>
-            <ButtonWrapper className={classNames("level-right", "is-flex")}>
-              <ButtonGroup>
-                <Button
-                  action={this.toggleSideBySide}
-                  icon={sideBySide ? "align-left" : "columns"}
-                  label={t(sideBySide ? "diff.combined" : "diff.sideBySide")}
-                  reducedMobile={true}
-                />
-                {fileControls}
-              </ButtonGroup>
-            </ButtonWrapper>
+            {sideBySideToggle}
           </FlexWrapLevel>
         </div>
         {body}