diff --git a/gradle/changelog/fixes.yaml b/gradle/changelog/fixes.yaml new file mode 100644 index 0000000000..40fb9188c6 --- /dev/null +++ b/gradle/changelog/fixes.yaml @@ -0,0 +1,6 @@ +- type: fixed + description: ConfigurationBinder Navlink does not only match exact routes +- type: changed + description: Move form list entry button to left side +- type: changed + description: Show empty message for form list table without entries diff --git a/scm-ui/ui-components/src/config/ConfigurationBinder.tsx b/scm-ui/ui-components/src/config/ConfigurationBinder.tsx index e6f8988013..8c3c7cee8a 100644 --- a/scm-ui/ui-components/src/config/ConfigurationBinder.tsx +++ b/scm-ui/ui-components/src/config/ConfigurationBinder.tsx @@ -55,7 +55,7 @@ class ConfigurationBinder { route(path: string, Component: any) { return ( - + {Component} ); @@ -70,7 +70,7 @@ class ConfigurationBinder { // create NavigationLink with translated label const ConfigNavLink = withTranslation(this.i18nNamespace)(({ t }) => { - return this.navLink("/admin/settings" + to, labelI18nKey, t); + return this.navLink("/admin/settings" + to, labelI18nKey, t, { activeOnlyWhenExact: false }); }); // bind navigation link to extension point @@ -151,7 +151,7 @@ class ConfigurationBinder { // create NavigationLink with translated label const RepoNavLink = withTranslation(this.i18nNamespace)(({ t, url }: RepositoryNavProps) => { - return this.navLink(url + "/settings" + to, labelI18nKey, t); + return this.navLink(url + "/settings" + to, labelI18nKey, t, { activeOnlyWhenExact: false }); }); // bind navigation link to extension point diff --git a/scm-ui/ui-forms/src/AddListEntryForm.tsx b/scm-ui/ui-forms/src/AddListEntryForm.tsx index 51f69d9991..c4c130082f 100644 --- a/scm-ui/ui-forms/src/AddListEntryForm.tsx +++ b/scm-ui/ui-forms/src/AddListEntryForm.tsx @@ -88,6 +88,9 @@ function AddListEntryForm, DefaultValue const submitButtonLabel = translateWithExtraPrefix("add", { defaultValue: defaultTranslate("list.add.label", { entity: translateWithExtraPrefix("entity") }), }); + const titleLabel = translateWithExtraPrefix("title", { + defaultValue: defaultTranslate("list.title.label", { entity: translateWithExtraPrefix("entity") }), + }); useEffect(() => { if (isSubmitSuccessful) { @@ -102,9 +105,10 @@ function AddListEntryForm, DefaultValue return ( +

{titleLabel}

{typeof children === "function" ? children(form) : children} -
+