From 9e12ba4b99542cd8ebaf37d6a52877c336fa9acc Mon Sep 17 00:00:00 2001
From: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
Date: Fri, 7 Dec 2012 17:50:34 +0100
Subject: [PATCH] improve logging of new event api

---
 .../java/sonia/scm/event/ScmEventBus.java     | 36 +++++++++++++++++--
 1 file changed, 34 insertions(+), 2 deletions(-)

diff --git a/scm-core/src/main/java/sonia/scm/event/ScmEventBus.java b/scm-core/src/main/java/sonia/scm/event/ScmEventBus.java
index 70bc0cf8b2..55b7b4a6b6 100644
--- a/scm-core/src/main/java/sonia/scm/event/ScmEventBus.java
+++ b/scm-core/src/main/java/sonia/scm/event/ScmEventBus.java
@@ -39,6 +39,9 @@ import com.google.common.eventbus.ThrowingEventBus;
 
 import org.apache.shiro.concurrent.SubjectAwareExecutorService;
 
+import org.slf4j.Logger;
+import org.slf4j.LoggerFactory;
+
 //~--- JDK imports ------------------------------------------------------------
 
 import java.util.concurrent.Executors;
@@ -51,6 +54,12 @@ import java.util.concurrent.Executors;
 public class ScmEventBus extends EventBus
 {
 
+  /**
+   * the logger for ScmEventBus
+   */
+  private static final Logger logger =
+    LoggerFactory.getLogger(ScmEventBus.class);
+
   /** Field description */
   private static ScmEventBus instance = new ScmEventBus();
 
@@ -91,6 +100,7 @@ public class ScmEventBus extends EventBus
   @Override
   public void post(Object event)
   {
+    logger.trace("post {} to event bus", event);
     asyncEventBus.post(event);
     eventBus.post(event);
   }
@@ -116,6 +126,8 @@ public class ScmEventBus extends EventBus
    */
   public void register(Object object, boolean async)
   {
+    logger.debug("register {} to event bus, async = {}", object, async);
+
     if (async)
     {
       asyncEventBus.register(object);
@@ -135,8 +147,28 @@ public class ScmEventBus extends EventBus
   @Override
   public void unregister(Object object)
   {
-    asyncEventBus.unregister(object);
-    eventBus.unregister(object);
+    logger.debug("unregister {} from event bus", object);
+    unregister(asyncEventBus, object);
+    unregister(eventBus, object);
+  }
+
+  /**
+   * Method description
+   *
+   *
+   * @param bus
+   * @param object
+   */
+  private void unregister(EventBus bus, Object object)
+  {
+    try
+    {
+      bus.unregister(object);
+    }
+    catch (IllegalArgumentException ex)
+    {
+      logger.debug("object {} was not registered at {}", object, bus);
+    }
   }
 
   //~--- fields ---------------------------------------------------------------