From 982d502203dc7e7bb865e2933278980e9477243c Mon Sep 17 00:00:00 2001 From: Johannes Schnatterer Date: Thu, 2 Aug 2018 13:18:21 +0200 Subject: [PATCH] Config Resources: Gets rid of unnecessary UriInfo param --- .../java/sonia/scm/api/v2/resources/GitConfigResource.java | 4 +--- .../java/sonia/scm/api/v2/resources/HgConfigResource.java | 6 ++---- .../java/sonia/scm/api/v2/resources/SvnConfigResource.java | 4 +--- .../java/sonia/scm/api/v2/resources/ConfigResource.java | 4 +--- 4 files changed, 5 insertions(+), 13 deletions(-) diff --git a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/api/v2/resources/GitConfigResource.java b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/api/v2/resources/GitConfigResource.java index 265a80ef6e..fe1f3c88d9 100644 --- a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/api/v2/resources/GitConfigResource.java +++ b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/api/v2/resources/GitConfigResource.java @@ -14,9 +14,7 @@ import javax.ws.rs.GET; import javax.ws.rs.PUT; import javax.ws.rs.Path; import javax.ws.rs.Produces; -import javax.ws.rs.core.Context; import javax.ws.rs.core.Response; -import javax.ws.rs.core.UriInfo; /** * RESTful Web Service Resource to manage the configuration of the git plugin. @@ -79,7 +77,7 @@ public class GitConfigResource { @ResponseCode(code = 500, condition = "internal server error") }) @TypeHint(TypeHint.NO_CONTENT.class) - public Response update(@Context UriInfo uriInfo, GitConfigDto configDto) { + public Response update(GitConfigDto configDto) { GitConfig config = dtoToConfigMapper.map(configDto); diff --git a/scm-plugins/scm-hg-plugin/src/main/java/sonia/scm/api/v2/resources/HgConfigResource.java b/scm-plugins/scm-hg-plugin/src/main/java/sonia/scm/api/v2/resources/HgConfigResource.java index 36838507ea..8966af91cd 100644 --- a/scm-plugins/scm-hg-plugin/src/main/java/sonia/scm/api/v2/resources/HgConfigResource.java +++ b/scm-plugins/scm-hg-plugin/src/main/java/sonia/scm/api/v2/resources/HgConfigResource.java @@ -14,9 +14,7 @@ import javax.ws.rs.GET; import javax.ws.rs.PUT; import javax.ws.rs.Path; import javax.ws.rs.Produces; -import javax.ws.rs.core.Context; import javax.ws.rs.core.Response; -import javax.ws.rs.core.UriInfo; /** * RESTful Web Service Resource to manage the configuration of the hg plugin. @@ -79,7 +77,7 @@ public class HgConfigResource { @ResponseCode(code = 500, condition = "internal server error") }) @TypeHint(TypeHint.NO_CONTENT.class) - public Response update(@Context UriInfo uriInfo, HgConfigDto configDto) { + public Response update(HgConfigDto configDto) { HgConfig config = dtoToConfigMapper.map(configDto); @@ -91,8 +89,8 @@ public class HgConfigResource { return Response.noContent().build(); } + // TODO - //* `auto-configuration` // * `packages` // * `packages/{pkgId}` // * `installations/hg` diff --git a/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/api/v2/resources/SvnConfigResource.java b/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/api/v2/resources/SvnConfigResource.java index c8050f41d3..bad9848ab5 100644 --- a/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/api/v2/resources/SvnConfigResource.java +++ b/scm-plugins/scm-svn-plugin/src/main/java/sonia/scm/api/v2/resources/SvnConfigResource.java @@ -14,9 +14,7 @@ import javax.ws.rs.GET; import javax.ws.rs.PUT; import javax.ws.rs.Path; import javax.ws.rs.Produces; -import javax.ws.rs.core.Context; import javax.ws.rs.core.Response; -import javax.ws.rs.core.UriInfo; /** * RESTful Web Service Resource to manage the configuration of the svn plugin. @@ -79,7 +77,7 @@ public class SvnConfigResource { @ResponseCode(code = 500, condition = "internal server error") }) @TypeHint(TypeHint.NO_CONTENT.class) - public Response update(@Context UriInfo uriInfo, SvnConfigDto configDto) { + public Response update(SvnConfigDto configDto) { SvnConfig config = dtoToConfigMapper.map(configDto); diff --git a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/ConfigResource.java b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/ConfigResource.java index 7bfa28f02b..9e61b50e86 100644 --- a/scm-webapp/src/main/java/sonia/scm/api/v2/resources/ConfigResource.java +++ b/scm-webapp/src/main/java/sonia/scm/api/v2/resources/ConfigResource.java @@ -14,9 +14,7 @@ import javax.ws.rs.GET; import javax.ws.rs.PUT; import javax.ws.rs.Path; import javax.ws.rs.Produces; -import javax.ws.rs.core.Context; import javax.ws.rs.core.Response; -import javax.ws.rs.core.UriInfo; @Path(ConfigResource.CONFIG_PATH_V2) public class ConfigResource { @@ -70,7 +68,7 @@ public class ConfigResource { @ResponseCode(code = 500, condition = "internal server error") }) @TypeHint(TypeHint.NO_CONTENT.class) - public Response update(ConfigDto configDto, @Context UriInfo uriInfo) { + public Response update(ConfigDto configDto) { // This *could* be moved to ScmConfiguration or ScmConfigurationUtil classes. // But to where to check? load() or store()? Leave it for now, SCMv1 legacy that can be cleaned up later.