From 980bd5b98c58c013e2dae811ebe807b033a3e530 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Tue, 24 Jul 2018 16:13:48 +0200 Subject: [PATCH] fixed failing tests and added helper for tests with i18n --- scm-ui/src/tests/i18n.js | 7 +++++++ scm-ui/src/users/containers/DeleteUserButton.test.js | 1 + scm-ui/src/users/containers/EditUserButton.test.js | 1 + scm-ui/src/users/modules/users.js | 2 -- 4 files changed, 9 insertions(+), 2 deletions(-) create mode 100644 scm-ui/src/tests/i18n.js diff --git a/scm-ui/src/tests/i18n.js b/scm-ui/src/tests/i18n.js new file mode 100644 index 0000000000..4f0dcc8f77 --- /dev/null +++ b/scm-ui/src/tests/i18n.js @@ -0,0 +1,7 @@ +jest.mock("react-i18next", () => ({ + // this mock makes sure any components using the translate HoC receive the t function as a prop + translate: () => Component => { + Component.defaultProps = { ...Component.defaultProps, t: key => key }; + return Component; + } +})); diff --git a/scm-ui/src/users/containers/DeleteUserButton.test.js b/scm-ui/src/users/containers/DeleteUserButton.test.js index fd0965c9ef..b44416056b 100644 --- a/scm-ui/src/users/containers/DeleteUserButton.test.js +++ b/scm-ui/src/users/containers/DeleteUserButton.test.js @@ -1,6 +1,7 @@ import React from "react"; import { mount, shallow } from "enzyme"; import "../../tests/enzyme"; +import "../../tests/i18n"; import DeleteUserButton from "./DeleteUserButton"; import { confirmAlert } from "../../components/ConfirmAlert"; diff --git a/scm-ui/src/users/containers/EditUserButton.test.js b/scm-ui/src/users/containers/EditUserButton.test.js index e02779143a..9c79e0ca33 100644 --- a/scm-ui/src/users/containers/EditUserButton.test.js +++ b/scm-ui/src/users/containers/EditUserButton.test.js @@ -1,6 +1,7 @@ import React from "react"; import { configure, shallow } from "enzyme"; import "../../tests/enzyme"; +import "../../tests/i18n"; import EditUserButton from "./EditUserButton"; it("should render nothing, if the edit link is missing", () => { diff --git a/scm-ui/src/users/modules/users.js b/scm-ui/src/users/modules/users.js index 1d6f186c14..fd5c3b8b2d 100644 --- a/scm-ui/src/users/modules/users.js +++ b/scm-ui/src/users/modules/users.js @@ -154,7 +154,6 @@ export function createUserPending(user: User) { }; } - export function createUserSuccess() { return { type: CREATE_USER_SUCCESS @@ -181,7 +180,6 @@ export function modifyUser(user: User) { dispatch(fetchUsers()); }) .catch(err => { - console.log(err); dispatch(modifyUserFailure(user, err)); }); };