From 97e9a92a81aef0dcb9184f29d42d02e42c306296 Mon Sep 17 00:00:00 2001 From: Thorsten Ludewig Date: Wed, 2 Feb 2011 09:52:45 +0100 Subject: [PATCH] some comments --- .../scm/auth/ldap/LDAPAuthenticationHandler.java | 11 +++++++---- 1 file changed, 7 insertions(+), 4 deletions(-) diff --git a/plugins/scm-auth-ldap-plugin/src/main/java/sonia/scm/auth/ldap/LDAPAuthenticationHandler.java b/plugins/scm-auth-ldap-plugin/src/main/java/sonia/scm/auth/ldap/LDAPAuthenticationHandler.java index 57f141c1bd..8ad504cae9 100644 --- a/plugins/scm-auth-ldap-plugin/src/main/java/sonia/scm/auth/ldap/LDAPAuthenticationHandler.java +++ b/plugins/scm-auth-ldap-plugin/src/main/java/sonia/scm/auth/ldap/LDAPAuthenticationHandler.java @@ -49,7 +49,6 @@ import sonia.scm.user.User; import sonia.scm.util.AssertUtil; import sonia.scm.web.security.AuthenticationHandler; import sonia.scm.web.security.AuthenticationResult; -import sonia.scm.web.security.AuthenticationState; //~--- JDK imports ------------------------------------------------------------ @@ -57,9 +56,7 @@ import java.io.IOException; import java.text.MessageFormat; -import java.util.ArrayList; import java.util.HashSet; -import java.util.List; import java.util.Properties; import java.util.Set; @@ -180,7 +177,7 @@ public class LDAPAuthenticationHandler implements AuthenticationHandler config.getAttributeNameMail()).get()); user.setType(TYPE); - // + // read group of unique names HashSet groups = new HashSet(); searchControls = new SearchControls(); @@ -213,8 +210,14 @@ public class LDAPAuthenticationHandler implements AuthenticationHandler // result = new AuthenticationResult(user, groups); + + // read dynamic group attribute getGroups(userAttributes, groups); + + // set admin user.setAdmin(isAdmin(user.getName(), groups)); + + // TODO: nsrole dn - admin role result = new AuthenticationResult(user, groups); } catch (NamingException ex)