From 9525cba06b137df07213d6dd5cf543f9be25ad8a Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Thu, 5 Dec 2019 15:20:47 +0100 Subject: [PATCH] suppress sonarqube nio performance warning --- scm-dao-xml/src/main/java/sonia/scm/store/CopyOnWrite.java | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/scm-dao-xml/src/main/java/sonia/scm/store/CopyOnWrite.java b/scm-dao-xml/src/main/java/sonia/scm/store/CopyOnWrite.java index 034472a904..135221ea82 100644 --- a/scm-dao-xml/src/main/java/sonia/scm/store/CopyOnWrite.java +++ b/scm-dao-xml/src/main/java/sonia/scm/store/CopyOnWrite.java @@ -21,6 +21,7 @@ public final class CopyOnWrite { replaceOriginalFile(targetFile, temporaryFile); } + @SuppressWarnings("squid:S3725") // performance of Files#isDirectory private static void validateInput(Path targetFile) { if (Files.isDirectory(targetFile)) { throw new IllegalArgumentException("target file has to be a regular file, not a directory"); @@ -36,7 +37,7 @@ public final class CopyOnWrite { Files.createFile(temporaryFile); } catch (IOException ex) { LOG.error("Error creating temporary file {} to replace file {}", temporaryFile, targetFile); - throw new StoreException("could create temporary file", ex); + throw new StoreException("could not create temporary file", ex); } return temporaryFile; } @@ -64,6 +65,7 @@ public final class CopyOnWrite { deleteBackupFile(backupFile); } + @SuppressWarnings("squid:S3725") // performance of Files#exists private static Path backupOriginalFile(Path targetFile) { Path directory = targetFile.getParent(); if (Files.exists(targetFile)) {