Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-07-04 09:49:26 +02:00
Code Issues Packages Projects Releases Activity

Validate namespaces correctly

Browse Source
This commit is contained in:
René Pfeuffer
2020-09-10 09:18:50 +02:00
parent 4df9c2947b
commit 94105f7766
4 changed files with 30 additions and 14 deletions
Download Patch File Download Diff File Expand all files Collapse all files

27
scm-webapp/src/test/java/sonia/scm/repository/CustomNamespaceStrategyTest.java
View File

@@ -21,10 +21,11 @@
* OUT OF OR IN CONNECTION WITH THE SOFTWARE OR THE USE OR OTHER DEALINGS IN THE
* SOFTWARE.
*/
package sonia.scm.repository;
import org.junit.jupiter.api.Test;
import org.junit.jupiter.params.ParameterizedTest;
import org.junit.jupiter.params.provider.ValueSource;
import sonia.scm.ScmConstraintViolationException;
import static org.assertj.core.api.Assertions.assertThat;
@@ -34,19 +35,21 @@ class CustomNamespaceStrategyTest {
private final NamespaceStrategy namespaceStrategy = new CustomNamespaceStrategy();
@Test
void shouldReturnNamespaceFromRepository() {
Repository heartOfGold = RepositoryTestData.createHeartOfGold();
assertThat(namespaceStrategy.createNamespace(heartOfGold)).isEqualTo(RepositoryTestData.NAMESPACE);
@ParameterizedTest
@ValueSource(strings = {"valid", "123_", "something_valid", "1234", "create_it"})
void shouldReturnNamespaceFromRepository(String expectedValidNamespace) {
Repository repository = RepositoryTestData.createHeartOfGold();
repository.setNamespace(expectedValidNamespace);
assertThat(namespaceStrategy.createNamespace(repository)).isEqualTo(expectedValidNamespace);
}
@Test
void shouldThrowAnValidationExceptionForAnInvalidNamespace() {
Repository repository = new Repository();
repository.setNamespace("..");
repository.setName(".");
@ParameterizedTest
@ValueSource(strings = {"..", " ", "0", "123", "create"})
void shouldThrowAnValidationExceptionForAnInvalidNamespace(String expectedAsInvalidNamespace) {
Repository repository = RepositoryTestData.createHeartOfGold();
repository.setNamespace(expectedAsInvalidNamespace);
assertThrows(ScmConstraintViolationException.class, () -> namespaceStrategy.createNamespace(repository));
}
}