diff --git a/scm-webapp/src/test/java/sonia/scm/api/v2/resources/RepositoryPermissionRootResourceTest.java b/scm-webapp/src/test/java/sonia/scm/api/v2/resources/RepositoryPermissionRootResourceTest.java index 5d9af10d09..2795562b14 100644 --- a/scm-webapp/src/test/java/sonia/scm/api/v2/resources/RepositoryPermissionRootResourceTest.java +++ b/scm-webapp/src/test/java/sonia/scm/api/v2/resources/RepositoryPermissionRootResourceTest.java @@ -82,11 +82,11 @@ public class RepositoryPermissionRootResourceTest extends RepositoryTestBase { private static final ArrayList TEST_PERMISSIONS = Lists .newArrayList( new RepositoryPermission("user_write", asList("read","modify"), false), - new RepositoryPermission("user_read", asList("read"), false), - new RepositoryPermission("user_owner", asList("*"), false), - new RepositoryPermission("group_read", asList("read"), true), + new RepositoryPermission("user_read", singletonList("read"), false), + new RepositoryPermission("user_owner", singletonList("*"), false), + new RepositoryPermission("group_read", singletonList("read"), true), new RepositoryPermission("group_write", asList("read","modify"), true), - new RepositoryPermission("group_owner", asList("*"), true) + new RepositoryPermission("group_owner", singletonList("*"), true) ); private final ExpectedRequest requestGETAllPermissions = new ExpectedRequest() .description("GET all permissions") diff --git a/scm-webapp/src/test/java/sonia/scm/repository/DefaultRepositoryManagerPerfTest.java b/scm-webapp/src/test/java/sonia/scm/repository/DefaultRepositoryManagerPerfTest.java index 8c643d59a2..3d00fcaa7e 100644 --- a/scm-webapp/src/test/java/sonia/scm/repository/DefaultRepositoryManagerPerfTest.java +++ b/scm-webapp/src/test/java/sonia/scm/repository/DefaultRepositoryManagerPerfTest.java @@ -111,7 +111,6 @@ public class DefaultRepositoryManagerPerfTest { public void setUpObjectUnderTest(){ when(repositoryHandler.getType()).thenReturn(new RepositoryType(REPOSITORY_TYPE, REPOSITORY_TYPE, Sets.newHashSet())); Set handlerSet = ImmutableSet.of(repositoryHandler); - RepositoryMatcher repositoryMatcher = new RepositoryMatcher(Collections.emptySet()); NamespaceStrategy namespaceStrategy = mock(NamespaceStrategy.class); repositoryManager = new DefaultRepositoryManager( configuration, @@ -138,7 +137,7 @@ public class DefaultRepositoryManagerPerfTest { /** * Start performance test and ensure that the timeout is not reached. */ - @Test(timeout = 6000l) + @Test(timeout = 6000L) public void perfTestGetAll(){ SecurityUtils.getSubject().login(new UsernamePasswordToken("trillian", "secret")); @@ -155,7 +154,7 @@ public class DefaultRepositoryManagerPerfTest { } private long calculateAverage(List times) { - Long sum = 0l; + Long sum = 0L; if(!times.isEmpty()) { for (Long time : times) { sum += time; @@ -183,9 +182,8 @@ private long calculateAverage(List times) { } private Repository createTestRepository(int number) { - Repository repository = new Repository(keyGenerator.createKey(), REPOSITORY_TYPE, "namespace", "repo-" + number); -// repository.addPermission(new RepositoryPermission("trillian", PermissionType.READ)); - return repository; + return new Repository(keyGenerator.createKey(), REPOSITORY_TYPE, "namespace", "repo-" + number); + } static class DummyRealm extends AuthorizingRealm {