From 924912b437ebd0b4a067897c1fdbb74e3f8a0dfe Mon Sep 17 00:00:00 2001 From: Rene Pfeuffer Date: Thu, 29 Aug 2019 13:19:14 +0200 Subject: [PATCH] Fix preconditions --- .../java/sonia/scm/repository/api/ModifyCommandBuilder.java | 2 +- .../java/sonia/scm/repository/spi/ModifyCommandRequest.java | 2 +- 2 files changed, 2 insertions(+), 2 deletions(-) diff --git a/scm-core/src/main/java/sonia/scm/repository/api/ModifyCommandBuilder.java b/scm-core/src/main/java/sonia/scm/repository/api/ModifyCommandBuilder.java index 9cfcaebd6a..0dbd45d0a0 100644 --- a/scm-core/src/main/java/sonia/scm/repository/api/ModifyCommandBuilder.java +++ b/scm-core/src/main/java/sonia/scm/repository/api/ModifyCommandBuilder.java @@ -115,7 +115,7 @@ public class ModifyCommandBuilder { */ public String execute() { try { - Preconditions.checkArgument(request.isValid(), "commit message, author and branch are required"); + Preconditions.checkArgument(request.isValid(), "commit message, branch and at least one request are required"); return command.execute(request); } finally { try { diff --git a/scm-core/src/main/java/sonia/scm/repository/spi/ModifyCommandRequest.java b/scm-core/src/main/java/sonia/scm/repository/spi/ModifyCommandRequest.java index 958cd4a485..94bf84ae70 100644 --- a/scm-core/src/main/java/sonia/scm/repository/spi/ModifyCommandRequest.java +++ b/scm-core/src/main/java/sonia/scm/repository/spi/ModifyCommandRequest.java @@ -65,7 +65,7 @@ public class ModifyCommandRequest implements Resetable, Validateable { @Override public boolean isValid() { - return StringUtils.isNotEmpty(commitMessage) && StringUtils.isNotEmpty(branch) && author != null && !requests.isEmpty(); + return StringUtils.isNotEmpty(commitMessage) && StringUtils.isNotEmpty(branch) && !requests.isEmpty(); } public interface PartialRequest {