Nemcio/SCM-Manager
1
0
Fork 0
mirror of https://github.com/scm-manager/scm-manager.git synced 2026-01-31 19:59:17 +01:00
Code Issues Packages Projects Releases Activity

fix event handling on repository import

Browse Source
This commit is contained in:
Eduard Heimbuch
2020-11-27 15:00:35 +01:00
parent 599639bc48
commit 8d96c5fdd2
2 changed files with 27 additions and 55 deletions
Download Patch File Download Diff File Expand all files Collapse all files

38
scm-webapp/src/main/java/sonia/scm/api/v2/resources/RepositoryImportResource.java
View File

@@ -235,10 +235,14 @@ public class RepositoryImportResource {
}
pullCommand.pull(request.getUrl());
eventBus.post(new RepositoryImportEvent(HandlerEventType.CREATE, repository, false));
} catch (IOException e) {
eventBus.post(new RepositoryImportEvent(HandlerEventType.MODIFY, repository, true));
throw new InternalRepositoryException(repository, "Failed to import from remote url", e);
} catch (Exception e) {
eventBus.post(new RepositoryImportEvent(HandlerEventType.MODIFY, repository, true));
throw e;
}
eventBus.post(new RepositoryImportEvent(HandlerEventType.MODIFY, repository, false));
};
}
@@ -471,38 +475,6 @@ public class RepositoryImportResource {
//
// return types;
// }
/**
* Handle creation failures.
*
* @param ex exception
* @param type repository type
* @param name name of the repository
*/
private void handleGenericCreationFailure(Exception ex, String type,
String name) {
logger.error(String.format("could not create repository %s with type %s",
type, name), ex);
throw new WebApplicationException(ex);
}
/**
* Handle import failures.
*
* @param ex exception
* @param repository repository
*/
private void handleImportFailure(Exception ex, Repository repository) {
logger.error("import for repository failed, delete repository", ex);
try {
eventBus.post(new RepositoryImportEvent(HandlerEventType.BEFORE_DELETE, repository, true));
} catch (InternalRepositoryException | NotFoundException e) {
logger.error("can not delete repository after import failure", e);
}
}
// /**
// * Import repositories from a specific type.
// *