From 89debd70c73e2df38ad38c4e7a4bed2fe6c655d7 Mon Sep 17 00:00:00 2001
From: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
Date: Fri, 15 Oct 2010 18:10:00 +0200
Subject: [PATCH] use constructor injection instead of field injection

---
 .../web/filter/BasicAuthenticationFilter.java    | 16 +++++++++++++++-
 .../java/sonia/scm/filter/SecurityFilter.java    | 15 ++++++++++++++-
 2 files changed, 29 insertions(+), 2 deletions(-)

diff --git a/scm-web-api/src/main/java/sonia/scm/web/filter/BasicAuthenticationFilter.java b/scm-web-api/src/main/java/sonia/scm/web/filter/BasicAuthenticationFilter.java
index 4feb642099..bfdb208866 100644
--- a/scm-web-api/src/main/java/sonia/scm/web/filter/BasicAuthenticationFilter.java
+++ b/scm-web-api/src/main/java/sonia/scm/web/filter/BasicAuthenticationFilter.java
@@ -57,6 +57,21 @@ public class BasicAuthenticationFilter extends HttpFilter
   /** Field description */
   public static final String HEADER_WWW_AUTHENTICATE = "WWW-Authenticate";
 
+  //~--- constructors ---------------------------------------------------------
+
+  /**
+   * Constructs ...
+   *
+   *
+   * @param securityContextProvider
+   */
+  @Inject
+  public BasicAuthenticationFilter(
+          Provider<SecurityContext> securityContextProvider)
+  {
+    this.securityContextProvider = securityContextProvider;
+  }
+
   //~--- methods --------------------------------------------------------------
 
   /**
@@ -140,6 +155,5 @@ public class BasicAuthenticationFilter extends HttpFilter
   //~--- fields ---------------------------------------------------------------
 
   /** Field description */
-  @Inject
   private Provider<SecurityContext> securityContextProvider;
 }
diff --git a/scm-webapp/src/main/java/sonia/scm/filter/SecurityFilter.java b/scm-webapp/src/main/java/sonia/scm/filter/SecurityFilter.java
index c1f766a683..efbd02d33b 100644
--- a/scm-webapp/src/main/java/sonia/scm/filter/SecurityFilter.java
+++ b/scm-webapp/src/main/java/sonia/scm/filter/SecurityFilter.java
@@ -37,6 +37,20 @@ public class SecurityFilter extends HttpFilter
   /** Field description */
   public static final String URL_AUTHENTICATION = "/api/rest/authentication";
 
+  //~--- constructors ---------------------------------------------------------
+
+  /**
+   * Constructs ...
+   *
+   *
+   * @param securityContextProvider
+   */
+  @Inject
+  public SecurityFilter(Provider<SecurityContext> securityContextProvider)
+  {
+    this.securityContextProvider = securityContextProvider;
+  }
+
   //~--- methods --------------------------------------------------------------
 
   /**
@@ -88,6 +102,5 @@ public class SecurityFilter extends HttpFilter
   //~--- fields ---------------------------------------------------------------
 
   /** Field description */
-  @Inject
   private Provider<SecurityContext> securityContextProvider;
 }