From 8733ca97afc95893dcfaa4eff6d9ee7a53953cb9 Mon Sep 17 00:00:00 2001
From: =?UTF-8?q?Ren=C3=A9=20Pfeuffer?= <rene.pfeuffer@cloudogu.com>
Date: Mon, 5 Oct 2020 08:18:37 +0200
Subject: [PATCH] Clean up class

---
 .../java/sonia/scm/security/ApiKeyRealm.java  | 27 ++++++++++++++-----
 1 file changed, 20 insertions(+), 7 deletions(-)

diff --git a/scm-webapp/src/main/java/sonia/scm/security/ApiKeyRealm.java b/scm-webapp/src/main/java/sonia/scm/security/ApiKeyRealm.java
index 776271f3d3..ed2954eb32 100644
--- a/scm-webapp/src/main/java/sonia/scm/security/ApiKeyRealm.java
+++ b/scm-webapp/src/main/java/sonia/scm/security/ApiKeyRealm.java
@@ -68,15 +68,16 @@ public class ApiKeyRealm extends AuthenticatingRealm {
       "%s is required", BearerToken.class);
     String password = getPassword(token);
     ApiKeyService.CheckResult check = apiKeyService.check(password);
-    RepositoryRole repositoryRole = repositoryRoleManager.get(check.getPermissionRole());
-    if (repositoryRole == null) {
-      throw new AuthorizationException("api key has unknown role: " + check.getPermissionRole());
-    }
-    String scope = "repository:" + String.join(",", repositoryRole.getVerbs()) + ":*";
+    return buildAuthenticationInfo(token, check);
+  }
+
+  private AuthenticationInfo buildAuthenticationInfo(AuthenticationToken token, ApiKeyService.CheckResult check) {
+    RepositoryRole repositoryRole = determineRole(check);
+    Scope scope = createScope(repositoryRole);
     return helper
       .authenticationInfoBuilder(check.getUser())
       .withSessionId(getPrincipal(token))
-      .withScope(Scope.valueOf(scope))
+      .withScope(scope)
       .build();
   }
 
@@ -88,11 +89,23 @@ public class ApiKeyRealm extends AuthenticatingRealm {
     }
   }
 
+  private RepositoryRole determineRole(ApiKeyService.CheckResult check) {
+    RepositoryRole repositoryRole = repositoryRoleManager.get(check.getPermissionRole());
+    if (repositoryRole == null) {
+      throw new AuthorizationException("api key has unknown role: " + check.getPermissionRole());
+    }
+    return repositoryRole;
+  }
+
+  private Scope createScope(RepositoryRole repositoryRole) {
+    return Scope.valueOf("repository:" + String.join(",", repositoryRole.getVerbs()) + ":*");
+  }
+
   private SessionId getPrincipal(AuthenticationToken token) {
     if (token instanceof BearerToken) {
       return ((BearerToken) token).getPrincipal();
     } else {
-      return SessionId.valueOf((((UsernamePasswordToken) token).getPrincipal()).toString());
+      return SessionId.valueOf((token.getPrincipal()).toString());
     }
   }
 }