From 861e1d34ca7e805a19a86c3332009db47a9e2c64 Mon Sep 17 00:00:00 2001
From: Eduard Heimbuch <eduard.heimbuch@cloudogu.com>
Date: Fri, 5 Mar 2021 10:10:02 +0100
Subject: [PATCH] Fix endless running test (#1572)

Fix endless running ui tests.

Co-authored-by: Sebastian Sdorra <sebastian.sdorra@cloudogu.com>
---
 scm-ui/ui-api/src/login.ts                    | 21 ++++---
 .../src/__snapshots__/storyshots.test.ts.snap | 60 +++++++++----------
 2 files changed, 40 insertions(+), 41 deletions(-)

diff --git a/scm-ui/ui-api/src/login.ts b/scm-ui/ui-api/src/login.ts
index b4daab0eb4..3ef4425e59 100644
--- a/scm-ui/ui-api/src/login.ts
+++ b/scm-ui/ui-api/src/login.ts
@@ -104,23 +104,22 @@ export const useLogout = () => {
   const link = useIndexLink("logout");
   const reset = useReset();
 
-  const { mutate, isLoading, error, data } = useMutation<LogoutResponse, Error, unknown>(() =>
-    apiClient.delete(link!).then(r => (r.status === 200 ? r.json() : {}))
+  const { mutate, isLoading, error, data } = useMutation<LogoutResponse, Error, unknown>(
+    () => apiClient.delete(link!).then(r => (r.status === 200 ? r.json() : {})),
+    {
+      onSuccess: response => {
+        if (response?.logoutRedirect) {
+          window.location.assign(response.logoutRedirect);
+        }
+        reset();
+      }
+    }
   );
 
   const logout = () => {
     mutate({});
   };
 
-  useEffect(() => {
-    if (data?.logoutRedirect) {
-      window.location.assign(data.logoutRedirect);
-    }
-    if (data) {
-      reset();
-    }
-  }, [data, reset]);
-
   return {
     logout: link && !data ? logout : undefined,
     isLoading,
diff --git a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
index 3decdfae60..b89821b4cd 100644
--- a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
+++ b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
@@ -3734,24 +3734,11 @@ Array [
     className="Breadcrumbstories__Wrapper-sc-1eq8sgz-0 hTbphm"
   >
     <div
-      className="is-flex is-align-items-center ml-5 my-4 mr-3"
+      className="is-flex is-align-items-center"
     >
-      <div
-        className="Breadcrumb__PermaLinkWrapper-zvtb4t-0 eqtJhO ml-1"
-      >
-        <span
-          className="tooltip has-tooltip-right"
-          data-tooltip="breadcrumb.copyPermalink"
-        >
-          <i
-            className="fas fa-link has-text-inherit"
-            onClick={[Function]}
-          />
-        </span>
-      </div>
       <nav
         aria-label="breadcrumbs"
-        className="Breadcrumb__BreadcrumbNav-zvtb4t-1 caWANn breadcrumb sources-breadcrumb ml-1 mb-0"
+        className="Breadcrumb__BreadcrumbNav-zvtb4t-1 gyUWqH breadcrumb sources-breadcrumb ml-1 mb-0"
       >
         <ul>
           <li>
@@ -3818,6 +3805,19 @@ Array [
             </a>
           </li>
         </ul>
+        <span
+          className="Breadcrumb__PermaLinkWrapper-zvtb4t-0 eqtJhO ml-1"
+        >
+          <span
+            className="tooltip has-tooltip-right"
+            data-tooltip="breadcrumb.copyPermalink"
+          >
+            <i
+              className="fas fa-link has-text-inherit"
+              onClick={[Function]}
+            />
+          </span>
+        </span>
       </nav>
     </div>
     <hr
@@ -4368,24 +4368,11 @@ Array [
     className="Breadcrumbstories__Wrapper-sc-1eq8sgz-0 hTbphm"
   >
     <div
-      className="is-flex is-align-items-center ml-5 my-4 mr-3"
+      className="is-flex is-align-items-center"
     >
-      <div
-        className="Breadcrumb__PermaLinkWrapper-zvtb4t-0 eqtJhO ml-1"
-      >
-        <span
-          className="tooltip has-tooltip-right"
-          data-tooltip="breadcrumb.copyPermalink"
-        >
-          <i
-            className="fas fa-link has-text-inherit"
-            onClick={[Function]}
-          />
-        </span>
-      </div>
       <nav
         aria-label="breadcrumbs"
-        className="Breadcrumb__BreadcrumbNav-zvtb4t-1 caWANn breadcrumb sources-breadcrumb ml-1 mb-0"
+        className="Breadcrumb__BreadcrumbNav-zvtb4t-1 gyUWqH breadcrumb sources-breadcrumb ml-1 mb-0"
       >
         <ul>
           <li>
@@ -4502,6 +4489,19 @@ Array [
             </a>
           </li>
         </ul>
+        <span
+          className="Breadcrumb__PermaLinkWrapper-zvtb4t-0 eqtJhO ml-1"
+        >
+          <span
+            className="tooltip has-tooltip-right"
+            data-tooltip="breadcrumb.copyPermalink"
+          >
+            <i
+              className="fas fa-link has-text-inherit"
+              onClick={[Function]}
+            />
+          </span>
+        </span>
       </nav>
     </div>
     <hr