From 84402b97227789c9c5f28c317324cfecb338d436 Mon Sep 17 00:00:00 2001
From: Konstantin Schaper <konstantin.schaper@cloudogu.com>
Date: Thu, 23 Jun 2022 11:52:21 +0200
Subject: [PATCH] allow card columns to omit the link (#2076)

The landing-page-plugin is using the CardColumnSmall component from ui-components to display event as tiles. Most events have a link, but some, like the RepositoryDeletedEvent do not. For a better UX it is therefore necessary, to have a CardColumnSmall that is not internally wrapped in a link.
---
 gradle/changelog/linkless_card_column.yaml    |  2 +
 .../src/CardColumnSmall.stories.tsx           |  8 ++++
 scm-ui/ui-components/src/CardColumnSmall.tsx  | 45 ++++++++++---------
 .../src/__snapshots__/storyshots.test.ts.snap | 43 ++++++++++++++++++
 4 files changed, 76 insertions(+), 22 deletions(-)
 create mode 100644 gradle/changelog/linkless_card_column.yaml

diff --git a/gradle/changelog/linkless_card_column.yaml b/gradle/changelog/linkless_card_column.yaml
new file mode 100644
index 0000000000..734c340da7
--- /dev/null
+++ b/gradle/changelog/linkless_card_column.yaml
@@ -0,0 +1,2 @@
+- type: added
+  description: Developers can omit the link prop of the CardColumnSmall component ([#2076](https://github.com/scm-manager/scm-manager/pull/2076))
diff --git a/scm-ui/ui-components/src/CardColumnSmall.stories.tsx b/scm-ui/ui-components/src/CardColumnSmall.stories.tsx
index 7154376eb0..080a879883 100644
--- a/scm-ui/ui-components/src/CardColumnSmall.stories.tsx
+++ b/scm-ui/ui-components/src/CardColumnSmall.stories.tsx
@@ -53,4 +53,12 @@ storiesOf("CardColumnSmall", module)
       contentRight={<small>over 42 years ago</small>}
       footer="New: scmadmin/spaceship"
     />
+  ))
+  .add("Linkless", () => (
+    <CardColumnSmall
+      avatar={<Icon name="eraser" className="fa-fw fa-lg" color="inherit" alt="avatar" />}
+      contentLeft={<strong>Repository deleted</strong>}
+      contentRight={<small>over 1337 minutes ago</small>}
+      footer="Deleted: scmadmin/spaceship"
+    />
   ));
diff --git a/scm-ui/ui-components/src/CardColumnSmall.tsx b/scm-ui/ui-components/src/CardColumnSmall.tsx
index 7f220890c0..c990bdd5d8 100644
--- a/scm-ui/ui-components/src/CardColumnSmall.tsx
+++ b/scm-ui/ui-components/src/CardColumnSmall.tsx
@@ -28,7 +28,7 @@ import styled from "styled-components";
 import { Link } from "react-router-dom";
 
 type Props = {
-  link: string;
+  link?: string;
   avatar?: ReactNode;
   contentLeft: ReactNode;
   contentRight: ReactNode;
@@ -42,30 +42,31 @@ const StyledLink = styled(Link)`
 const CardColumnSmall: FC<Props> = ({ link, avatar, contentLeft, contentRight, footer }) => {
   const renderAvatar = avatar ? <figure className="media-left mr-2 mt-1">{avatar}</figure> : null;
   const renderFooter = footer ? <small>{footer}</small> : null;
-
-  return (
-    <StyledLink to={link}>
-      <div className="p-2 media has-hover-background-blue">
-        {renderAvatar}
-        <div
-          className={classNames(
-            "media-content",
-            "text-box",
-            "is-flex",
-            "is-flex-direction-column",
-            "is-justify-content-space-around",
-            "is-align-self-stretch"
-          )}
-        >
-          <div className="is-flex is-flex-direction-column is-flex-align-items-start">
-            <div className="is-clipped">{contentLeft}</div>
-            <div>{contentRight}</div>
-          </div>
-          {renderFooter}
+  const content = (
+    <div className="p-2 media has-hover-background-blue">
+      {renderAvatar}
+      <div
+        className={classNames(
+          "media-content",
+          "text-box",
+          "is-flex",
+          "is-flex-direction-column",
+          "is-justify-content-space-around",
+          "is-align-self-stretch"
+        )}
+      >
+        <div className="is-flex is-flex-direction-column is-flex-align-items-start">
+          <div className="is-clipped">{contentLeft}</div>
+          <div>{contentRight}</div>
         </div>
+        {renderFooter}
       </div>
-    </StyledLink>
+    </div>
   );
+  if (!link) {
+    return content;
+  }
+  return <StyledLink to={link}>{content}</StyledLink>;
 };
 
 export default CardColumnSmall;
diff --git a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
index 56ae2b057c..583f2c39c6 100644
--- a/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
+++ b/scm-ui/ui-components/src/__snapshots__/storyshots.test.ts.snap
@@ -1282,6 +1282,49 @@ exports[`Storyshots CardColumnSmall Default 1`] = `
 </div>
 `;
 
+exports[`Storyshots CardColumnSmall Linkless 1`] = `
+<div
+  className="CardColumnSmallstories__Wrapper-sc-ofr817-0 jjqVte"
+>
+  <div
+    className="p-2 media has-hover-background-blue"
+  >
+    <figure
+      className="media-left mr-2 mt-1"
+    >
+      <i
+        aria-label="avatar"
+        className="fas fa-fw fa-eraser has-text-inherit fa-fw fa-lg"
+        onKeyPress={[Function]}
+      />
+    </figure>
+    <div
+      className="media-content text-box is-flex is-flex-direction-column is-justify-content-space-around is-align-self-stretch"
+    >
+      <div
+        className="is-flex is-flex-direction-column is-flex-align-items-start"
+      >
+        <div
+          className="is-clipped"
+        >
+          <strong>
+            Repository deleted
+          </strong>
+        </div>
+        <div>
+          <small>
+            over 1337 minutes ago
+          </small>
+        </div>
+      </div>
+      <small>
+        Deleted: scmadmin/spaceship
+      </small>
+    </div>
+  </div>
+</div>
+`;
+
 exports[`Storyshots CardColumnSmall Minimal 1`] = `
 <div
   className="CardColumnSmallstories__Wrapper-sc-ofr817-0 jjqVte"