From 8330f8fddd6218e9c637d83c0216c1fa3166cfe3 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Mon, 16 Aug 2021 13:11:44 +0200 Subject: [PATCH] Fix submission of empty search queries (#1769) Fixes submission of OmniSearch with an empty query or one which contains only a single character. --- gradle/changelog/search_without_query.yaml | 2 ++ scm-ui/ui-webapp/src/containers/OmniSearch.tsx | 6 ++++-- 2 files changed, 6 insertions(+), 2 deletions(-) create mode 100644 gradle/changelog/search_without_query.yaml diff --git a/gradle/changelog/search_without_query.yaml b/gradle/changelog/search_without_query.yaml new file mode 100644 index 0000000000..6edf885dd6 --- /dev/null +++ b/gradle/changelog/search_without_query.yaml @@ -0,0 +1,2 @@ +- type: Fixed + description: Submission of empty search queries ([#1769](https://github.com/scm-manager/scm-manager/pull/1769)) diff --git a/scm-ui/ui-webapp/src/containers/OmniSearch.tsx b/scm-ui/ui-webapp/src/containers/OmniSearch.tsx index 460609daa8..e6f0bca5d5 100644 --- a/scm-ui/ui-webapp/src/containers/OmniSearch.tsx +++ b/scm-ui/ui-webapp/src/containers/OmniSearch.tsx @@ -353,8 +353,10 @@ const OmniSearch: FC = () => { const clearQuery = () => setQuery(""); const gotoDetailSearch = () => { - history.push(`/search/${searchType}/?q=${query}`); - hideResults(); + if (query.length > 1) { + history.push(`/search/${searchType}/?q=${query}`); + hideResults(); + } }; const { onKeyDown, index } = useKeyBoardNavigation(gotoDetailSearch, clearQuery, data?._embedded.hits);