From 826d7833db080a3e89550de1e698741176935575 Mon Sep 17 00:00:00 2001 From: Sebastian Sdorra Date: Sun, 24 Jun 2012 19:52:59 +0200 Subject: [PATCH] revert cloning of command results for performance reasons --- .../main/java/sonia/scm/repository/api/BlameCommandBuilder.java | 2 -- .../java/sonia/scm/repository/api/BrowseCommandBuilder.java | 1 - .../main/java/sonia/scm/repository/api/LogCommandBuilder.java | 2 -- 3 files changed, 5 deletions(-) diff --git a/scm-core/src/main/java/sonia/scm/repository/api/BlameCommandBuilder.java b/scm-core/src/main/java/sonia/scm/repository/api/BlameCommandBuilder.java index 7863613963..aadff564a2 100644 --- a/scm-core/src/main/java/sonia/scm/repository/api/BlameCommandBuilder.java +++ b/scm-core/src/main/java/sonia/scm/repository/api/BlameCommandBuilder.java @@ -188,8 +188,6 @@ public final class BlameCommandBuilder if (!disablePreProcessors && (result != null)) { - // clone result to fix pre processor behavior - result = result.clone(); preProcessorUtil.prepareForReturn(repository, result); } diff --git a/scm-core/src/main/java/sonia/scm/repository/api/BrowseCommandBuilder.java b/scm-core/src/main/java/sonia/scm/repository/api/BrowseCommandBuilder.java index bb78e4a661..053ef06ac9 100644 --- a/scm-core/src/main/java/sonia/scm/repository/api/BrowseCommandBuilder.java +++ b/scm-core/src/main/java/sonia/scm/repository/api/BrowseCommandBuilder.java @@ -184,7 +184,6 @@ public final class BrowseCommandBuilder if (!disablePreProcessors && (result != null)) { - result = result.clone(); preProcessorUtil.prepareForReturn(repository, result); List fileObjects = result.getFiles(); diff --git a/scm-core/src/main/java/sonia/scm/repository/api/LogCommandBuilder.java b/scm-core/src/main/java/sonia/scm/repository/api/LogCommandBuilder.java index 951f46763a..bfa337ea6f 100644 --- a/scm-core/src/main/java/sonia/scm/repository/api/LogCommandBuilder.java +++ b/scm-core/src/main/java/sonia/scm/repository/api/LogCommandBuilder.java @@ -214,7 +214,6 @@ public final class LogCommandBuilder if (!disablePreProcessors && (changeset != null)) { - changeset = changeset.clone(); preProcessorUtil.prepareForReturn(repository, changeset); } @@ -272,7 +271,6 @@ public final class LogCommandBuilder if (!disablePreProcessors && (cpr != null)) { - cpr = cpr.clone(); preProcessorUtil.prepareForReturn(repository, cpr); }