From 8232938afdbe6d61fa6e97d712b7b41dc865c1ae Mon Sep 17 00:00:00 2001 From: Mohamed Karray Date: Thu, 6 Dec 2018 18:01:39 +0100 Subject: [PATCH] use protected constant and mutableSet for final field --- .../java/sonia/scm/repository/GitRepositoryHandler.java | 7 +++---- .../scm/repository/spi/GitRepositoryServiceProvider.java | 5 +++-- 2 files changed, 6 insertions(+), 6 deletions(-) diff --git a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/GitRepositoryHandler.java b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/GitRepositoryHandler.java index 4d83d14d5d..95225c9e30 100644 --- a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/GitRepositoryHandler.java +++ b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/GitRepositoryHandler.java @@ -43,7 +43,6 @@ import org.eclipse.jgit.storage.file.FileRepositoryBuilder; import org.slf4j.Logger; import org.slf4j.LoggerFactory; import sonia.scm.SCMContextProvider; -import sonia.scm.io.FileSystem; import sonia.scm.plugin.Extension; import sonia.scm.repository.spi.GitRepositoryServiceProvider; import sonia.scm.schedule.Scheduler; @@ -97,7 +96,7 @@ public class GitRepositoryHandler private final GitWorkdirFactory workdirFactory; private Task task; - + //~--- constructors --------------------------------------------------------- @Inject @@ -126,7 +125,7 @@ public class GitRepositoryHandler scheduleGc(config.getGcExpression()); super.setConfig(config); } - + private void scheduleGc(String expression) { synchronized (LOCK){ @@ -142,7 +141,7 @@ public class GitRepositoryHandler } } } - + /** * Method description * diff --git a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitRepositoryServiceProvider.java b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitRepositoryServiceProvider.java index 6c2c4423f9..936962eaba 100644 --- a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitRepositoryServiceProvider.java +++ b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/GitRepositoryServiceProvider.java @@ -33,6 +33,7 @@ package sonia.scm.repository.spi; +import com.google.common.collect.ImmutableSet; import sonia.scm.repository.Feature; import sonia.scm.repository.GitRepositoryHandler; import sonia.scm.repository.Repository; @@ -53,7 +54,7 @@ public class GitRepositoryServiceProvider extends RepositoryServiceProvider /** Field description */ //J- - public static final Set COMMANDS = EnumSet.of( + public static final Set COMMANDS = ImmutableSet.of( Command.BLAME, Command.BROWSE, Command.CAT, @@ -67,7 +68,7 @@ public class GitRepositoryServiceProvider extends RepositoryServiceProvider Command.PULL, Command.MERGE ); - public static final Set FEATURES = EnumSet.of(Feature.INCOMING_REVISION); + protected static final Set FEATURES = EnumSet.of(Feature.INCOMING_REVISION); //J+ //~--- constructors ---------------------------------------------------------