From 7b03c19de6ce19037906269bccc9aa89bf999ad1 Mon Sep 17 00:00:00 2001 From: broDom Date: Mon, 3 Jul 2017 17:08:44 +0200 Subject: [PATCH] refactor: replace while loop with Map.removeIf --- .../cli/cmd/DeletePermissionSubCommand.java | 18 +++--------------- 1 file changed, 3 insertions(+), 15 deletions(-) diff --git a/scm-clients/scm-cli-client/src/main/java/sonia/scm/cli/cmd/DeletePermissionSubCommand.java b/scm-clients/scm-cli-client/src/main/java/sonia/scm/cli/cmd/DeletePermissionSubCommand.java index fe01b3ff24..2b482c0f4e 100644 --- a/scm-clients/scm-cli-client/src/main/java/sonia/scm/cli/cmd/DeletePermissionSubCommand.java +++ b/scm-clients/scm-cli-client/src/main/java/sonia/scm/cli/cmd/DeletePermissionSubCommand.java @@ -36,14 +36,12 @@ package sonia.scm.cli.cmd; //~--- non-JDK imports -------------------------------------------------------- import org.kohsuke.args4j.Option; - import sonia.scm.repository.Permission; -//~--- JDK imports ------------------------------------------------------------ - -import java.util.Iterator; import java.util.List; +//~--- JDK imports ------------------------------------------------------------ + /** * * @author Sebastian Sdorra @@ -91,17 +89,7 @@ public class DeletePermissionSubCommand extends PermissionSubCommand @Override protected void modifyPermissions(List permissions) { - Iterator it = permissions.iterator(); - - while (it.hasNext()) - { - Permission p = it.next(); - - if (name.equals(p.getName())) - { - it.remove(); - } - } + permissions.removeIf(p -> name.equals(p.getName())); } //~--- fields ---------------------------------------------------------------