From 7a65ed6ff818f23aa6fa17257c0ae1a9b4be83d3 Mon Sep 17 00:00:00 2001
From: Philipp Czora <philipp.czora@cloudogu.com>
Date: Fri, 3 Aug 2018 10:37:56 +0200
Subject: [PATCH] Extracted AddUserField

---
 scm-ui/public/locales/en/groups.json         |   7 ++
 scm-ui/src/components/buttons/Button.js      |   4 +-
 scm-ui/src/groups/components/AddUserField.js |  54 +++++++++
 scm-ui/src/groups/components/GroupForm.js    | 115 ++++++++++---------
 4 files changed, 123 insertions(+), 57 deletions(-)
 create mode 100644 scm-ui/src/groups/components/AddUserField.js

diff --git a/scm-ui/public/locales/en/groups.json b/scm-ui/public/locales/en/groups.json
index 4f2cdbac92..873d88a809 100644
--- a/scm-ui/public/locales/en/groups.json
+++ b/scm-ui/public/locales/en/groups.json
@@ -29,6 +29,13 @@
   "edit-group-button": {
     "label": "Edit"
   },
+  "add-user-button": {
+    "label": "Add user"
+  },
+  "add-user-textfield": {
+    "label": "Add user",
+    "error": "Error adding user"
+  },
   "group-form": {
     "submit": "Submit",
     "name-error": "Group name is invalid",
diff --git a/scm-ui/src/components/buttons/Button.js b/scm-ui/src/components/buttons/Button.js
index 242950ef11..c087da61e5 100644
--- a/scm-ui/src/components/buttons/Button.js
+++ b/scm-ui/src/components/buttons/Button.js
@@ -7,7 +7,7 @@ export type ButtonProps = {
   label: string,
   loading?: boolean,
   disabled?: boolean,
-  action?: () => void,
+  action?: (event: Event) => void,
   link?: string,
   fullWidth?: boolean,
   className?: string
@@ -37,7 +37,7 @@ class Button extends React.Component<Props> {
     return (
       <button
         disabled={disabled}
-        onClick={action ? action : () => {}}
+        onClick={action ? action : (event: Event) => {}}
         className={classNames(
           "button",
           "is-" + type,
diff --git a/scm-ui/src/groups/components/AddUserField.js b/scm-ui/src/groups/components/AddUserField.js
new file mode 100644
index 0000000000..6fcb5770a0
--- /dev/null
+++ b/scm-ui/src/groups/components/AddUserField.js
@@ -0,0 +1,54 @@
+//@flow
+import React from "react";
+
+import { translate } from "react-i18next";
+import AddButton from "../../components/buttons/AddButton";
+import InputField from "../../components/forms/InputField";
+
+type Props = {
+  t: string => string,
+  addUser: string => void
+};
+
+type State = {
+  userToAdd: string
+};
+
+class AddUserField extends React.Component<Props, State> {
+  constructor(props) {
+    super(props);
+    this.state = {
+      userToAdd: ""
+    };
+  }
+  render() {
+    const { t } = this.props;
+    return (
+      <div className="field">
+        <InputField
+          label={t("add-user-textfield.label")}
+          errorMessage={t("add-user-textfield.error")}
+          onChange={this.handleAddUserChange}
+          validationError={false} //TODO: validate user name
+          value={this.state.userToAdd}
+        />
+        <AddButton
+          label={t("add-user-button.label")}
+          action={this.addButtonClicked}
+        />
+      </div>
+    );
+  }
+
+  addButtonClicked = (event: Event) => {
+    event.preventDefault();
+    this.props.addUser(this.state.userToAdd);
+    this.setState({ ...this.state, userToAdd: "" });
+  };
+
+  handleAddUserChange = (username: string) => {
+    this.setState({ ...this.state, userToAdd: username });
+  };
+}
+
+export default translate("groups")(AddUserField);
diff --git a/scm-ui/src/groups/components/GroupForm.js b/scm-ui/src/groups/components/GroupForm.js
index 00904112bc..04374782d9 100644
--- a/scm-ui/src/groups/components/GroupForm.js
+++ b/scm-ui/src/groups/components/GroupForm.js
@@ -6,6 +6,7 @@ import { SubmitButton, Button } from "../../components/buttons";
 import { translate } from "react-i18next";
 import type { Group } from "../types/Group";
 import * as validator from "./groupValidation";
+import AddUserField from "./AddUserField";
 
 type Props = {
   t: string => string,
@@ -16,7 +17,6 @@ type Props = {
 
 type State = {
   group: Group,
-  userToAdd: string,
   nameValidationError: boolean
 };
 
@@ -34,15 +34,14 @@ class GroupForm extends React.Component<Props, State> {
         members: [],
         type: ""
       },
-      nameValidationError: false,
-      userToAdd: ""
+      nameValidationError: false
     };
   }
 
   componentDidMount() {
-    const { group } = this.props
+    const { group } = this.props;
     if (group) {
-      this.setState({group: {...group}})
+      this.setState({...this.state, group: { ...group } });
     }
   }
 
@@ -56,7 +55,7 @@ class GroupForm extends React.Component<Props, State> {
   isValid = () => {
     const group = this.state.group;
     return !(
-      this.state.nameValidationError || 
+      this.state.nameValidationError ||
       this.isFalsy(group.name) ||
       this.isFalsy(group.description)
     );
@@ -69,23 +68,23 @@ class GroupForm extends React.Component<Props, State> {
     }
   };
 
-render() {
+  render() {
     const { t, loading } = this.props;
-    const group = this.state.group
+    const group = this.state.group;
     let nameField = null;
     if (!this.props.group) {
       nameField = (
         <InputField
-        label={t("group.name")}
-        errorMessage={t("group-form.name-error")}
-        onChange={this.handleGroupNameChange}
-        value={group.name}
-        validationError={this.state.nameValidationError}
-      />
+          label={t("group.name")}
+          errorMessage={t("group-form.name-error")}
+          onChange={this.handleGroupNameChange}
+          value={group.name}
+          validationError={this.state.nameValidationError}
+        />
       );
     }
 
-    return (   
+    return (
       <form onSubmit={this.submit}>
         {nameField}
         <InputField
@@ -97,49 +96,62 @@ render() {
         />
         <label className="label">{t("group.members")}</label>
         <table className="table is-hoverable is-fullwidth">
-        <tbody>
-          {this.state.group.members.map((user, index) => {
-            return <tr key={user}>
-            <td key={user}>{user}</td>
-            <td><Button label="Remove" action={this.removeUser.bind(this, user)} key={user}/></td>
-            </tr>
-          })}
-        </tbody>
-      </table>
-        <InputField
-          label="Add user"
-          errorMessage="Error"
-          onChange={this.handleAddUserChange}
-          validationError={false} 
-          value={this.state.userToAdd}/>
-        
-          <Button label="Add user" action={this.addUserClick} />
+          <tbody>
+            {this.state.group.members.map((user, index) => {
+              return (
+                <tr key={user}>
+                  <td key={user}>{user}</td>
+                  <td>
+                    <Button
+                      label="Remove"
+                      action={this.removeUser.bind(this, user)}
+                      key={user}
+                    />
+                  </td>
+                </tr>
+              );
+            })}
+          </tbody>
+        </table>
 
-          <SubmitButton disabled={!this.isValid()} label={t("group-form.submit")} loading={loading}/>
+        <AddUserField addUser={this.addUser} />
+        <SubmitButton
+          disabled={!this.isValid()}
+          label={t("group-form.submit")}
+          loading={loading}
+        />
       </form>
     );
   }
 
-removeUser(user: string, event: Event) {
-    event.preventDefault();
-    let newMembers = this.state.group.members.filter(name => name !== user)
-    this.setState({...this.state, group: {
-      ...this.state.group,
-      members: newMembers}
-    })
-  }
-
-
-
-  addUserClick = (event: Event) => {
+  removeUser(user: string, event: Event) {
     event.preventDefault();
+    let newMembers = this.state.group.members.filter(name => name !== user);
     this.setState({
       ...this.state,
-      userToAdd: "",
       group: {
         ...this.state.group,
-        members: [...this.state.group.members, this.state.userToAdd]}
-    })
+        members: newMembers
+      }
+    });
+  }
+
+  addUser = (username: string) => {
+    if (this.isMember(username)) {
+      return;
+    }
+
+    this.setState({
+      ...this.state,
+      group: {
+        ...this.state.group,
+        members: [...this.state.group.members, username]
+      }
+    });
+  }
+
+  isMember = (username: string) => {
+    return this.state.group.members.includes(username)
   }
 
   handleGroupNameChange = (name: string) => {
@@ -154,13 +166,6 @@ removeUser(user: string, event: Event) {
       group: { ...this.state.group, description }
     });
   };
-
-  handleAddUserChange = (username: string) => {
-    this.setState({
-      ...this.state,
-      userToAdd: username
-    })
-  }
 }
 
 export default translate("groups")(GroupForm);