Mark span as failed if an IOException occurs

This commit is contained in:
Sebastian Sdorra
2020-10-27 08:15:10 +01:00
parent 1742bd9b77
commit 76dee09e3c
2 changed files with 37 additions and 18 deletions

View File

@@ -193,12 +193,18 @@ public class DefaultAdvancedHttpClient extends AdvancedHttpClient
try (Span span = tracer.span(request.getSpanKind())) {
span.label("url", request.getUrl());
span.label("method", request.getMethod());
DefaultAdvancedHttpResponse response = doRequest(request);
span.label("status", response.getStatus());
if (!response.isSuccessful()) {
try {
DefaultAdvancedHttpResponse response = doRequest(request);
span.label("status", response.getStatus());
if (!response.isSuccessful()) {
span.failed();
}
return response;
} catch (IOException ex) {
span.label("exception", ex.getMessage());
span.failed();
throw ex;
}
return response;
}
}