From 76354aa83911f4cee53aeecb4062872ceef3b0cd Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?Ren=C3=A9=20Pfeuffer?= Date: Tue, 12 May 2020 14:40:26 +0200 Subject: [PATCH] Close diff formatter --- .../java/sonia/scm/repository/spi/Differ.java | 19 ++++++++++--------- 1 file changed, 10 insertions(+), 9 deletions(-) diff --git a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/Differ.java b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/Differ.java index c8ed2e6e51..c613e945f1 100644 --- a/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/Differ.java +++ b/scm-plugins/scm-git-plugin/src/main/java/sonia/scm/repository/spi/Differ.java @@ -113,16 +113,17 @@ final class Differ implements AutoCloseable { } private Diff diff(Repository repository) throws IOException { - DiffFormatter diffFormatter = new DiffFormatter(null); - diffFormatter.setRepository(repository); - diffFormatter.setDetectRenames(true); - if (pathFilter != null) { - diffFormatter.setPathFilter(pathFilter); + try (DiffFormatter diffFormatter = new DiffFormatter(null)) { + diffFormatter.setRepository(repository); + diffFormatter.setDetectRenames(true); + if (pathFilter != null) { + diffFormatter.setPathFilter(pathFilter); + } + List entries = diffFormatter.scan( + treeWalk.getTree(0, AbstractTreeIterator.class), + treeWalk.getTree(1, AbstractTreeIterator.class)); + return new Diff(commit, entries); } - List entries = diffFormatter.scan( - treeWalk.getTree(0, AbstractTreeIterator.class), - treeWalk.getTree(1, AbstractTreeIterator.class)); - return new Diff(commit, entries); } @Override