diff --git a/scm-ui/src/permissions/components/table/PermissionRow.js b/scm-ui/src/permissions/components/table/PermissionRow.js deleted file mode 100644 index 91b0fa6741..0000000000 --- a/scm-ui/src/permissions/components/table/PermissionRow.js +++ /dev/null @@ -1,23 +0,0 @@ -// @flow -import React from "react"; -import type { Permission } from "../../types/Permissions"; -import { Checkbox } from "../../../components/forms"; - -type Props = { - permission: Permission -}; - -export default class PermissionRow extends React.Component { - render() { - const { permission } = this.props; - return ( - - {permission.name} - {permission.type} - - - - - ); - } -} diff --git a/scm-ui/src/permissions/containers/Permissions.js b/scm-ui/src/permissions/containers/Permissions.js index 9693826065..b02e0c778e 100644 --- a/scm-ui/src/permissions/containers/Permissions.js +++ b/scm-ui/src/permissions/containers/Permissions.js @@ -6,12 +6,12 @@ import { fetchPermissions, getFetchPermissionsFailure, isFetchPermissionsPending, - getPermissionsOfRepo, + getPermissionsOfRepo } from "../modules/permissions"; import Loading from "../../components/Loading"; import ErrorPage from "../../components/ErrorPage"; import type { PermissionCollection } from "../types/Permissions"; -import PermissionsTable from "./PermissionsTable"; +import SinglePermission from "./SinglePermission"; type Props = { namespace: string, @@ -53,11 +53,27 @@ class Permissions extends React.Component { if (permissions.length > 0) return ( - + + + + + + + + + + {permissions.map((permission, index) => { + return ( + + ); + })} + +
{t("permission.name")}{t("permission.type")}{t("permission.group-permission")}
); return
; diff --git a/scm-ui/src/permissions/containers/PermissionsTable.js b/scm-ui/src/permissions/containers/PermissionsTable.js deleted file mode 100644 index 4b6bdac23e..0000000000 --- a/scm-ui/src/permissions/containers/PermissionsTable.js +++ /dev/null @@ -1,57 +0,0 @@ -// @flow -import React from "react"; -import { translate } from "react-i18next"; -import PermissionRow from "../components/table/PermissionRow"; -import type { Permission, PermissionCollection } from "../types/Permissions"; -import SinglePermission from "./SinglePermission"; -import type { History } from "history"; - -type Props = { - t: string => string, - permissions: PermissionCollection, - modifyPermission: (Permission, string, string, () => void) => void, - namespace: string, - name: string, - match: any, - history: History -}; - -class PermissionsTable extends React.Component { - permissionsModified = () => { - const { history, name, namespace } = this.props; - console.log(history); - history.push(`/repo/${namespace}/${name}/permissions`); - }; - - render() { - const { permissions, t, namespace, name } = this.props; - - return ( - - - - - - - - - - {permissions.map((permission, index) => { - if (permission._links.update) - return ( - - ); - else return ; - })} - -
{t("permission.name")}{t("permission.type")}{t("permission.group-permission")}
- ); - } -} - -export default translate("permissions")(PermissionsTable); diff --git a/scm-ui/src/permissions/containers/SinglePermission.js b/scm-ui/src/permissions/containers/SinglePermission.js index 403efd5e1b..9730282330 100644 --- a/scm-ui/src/permissions/containers/SinglePermission.js +++ b/scm-ui/src/permissions/containers/SinglePermission.js @@ -62,19 +62,25 @@ class SinglePermission extends React.Component { ) : null; + const typeSelector = this.props.permission._links.update ? ( + + - + {typeSelector} {deleteButton} );